| Message ID | 20191024091948.10569-1-yhchuang@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5c70e97142542c4d22e8892568c035bc95049258 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: fix GENMASK_ULL for u64 | expand |
<yhchuang@realtek.com> writes: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > This fixes compile warning: > > In file included from include/linux/bitops.h:5:0, > from include/linux/kernel.h:12, > from include/asm-generic/bug.h:19, > from arch/mips/include/asm/bug.h:42, > from include/linux/bug.h:5, > from include/net/mac80211.h:16, > from drivers/net/wireless/realtek/rtw88/main.h:8, > from drivers/net/wireless/realtek/rtw88/main.c:5: > drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask': > include/linux/bits.h:23:11: warning: right shift count is negative > [-Wshift-count-negative] > (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) > ^ > drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK' > u64 cfg_mask = GENMASK(63, 0); > ^~~~~~~ > > Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support") > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> I'll add: Reported-by: kbuild test robot <lkp@intel.com>
> Subject: Re: [PATCH] rtw88: fix GENMASK_ULL for u64 > > <yhchuang@realtek.com> writes: > > > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > > This fixes compile warning: > > > > In file included from include/linux/bitops.h:5:0, > > from include/linux/kernel.h:12, > > from include/asm-generic/bug.h:19, > > from arch/mips/include/asm/bug.h:42, > > from include/linux/bug.h:5, > > from include/net/mac80211.h:16, > > from > drivers/net/wireless/realtek/rtw88/main.h:8, > > from > drivers/net/wireless/realtek/rtw88/main.c:5: > > drivers/net/wireless/realtek/rtw88/main.c: In function > 'rtw_update_rate_mask': > > include/linux/bits.h:23:11: warning: right shift count is negative > > [-Wshift-count-negative] > > (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) > > ^ > > drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion > of macro 'GENMASK' > > u64 cfg_mask = GENMASK(63, 0); > > ^~~~~~~ > > > > Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support") > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > > I'll add: > > Reported-by: kbuild test robot <lkp@intel.com> > Yes, please add it, I forgot about it. Thanks Yan-Hsuan
<yhchuang@realtek.com> wrote: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > This fixes compile warning: > > In file included from include/linux/bitops.h:5:0, > from include/linux/kernel.h:12, > from include/asm-generic/bug.h:19, > from arch/mips/include/asm/bug.h:42, > from include/linux/bug.h:5, > from include/net/mac80211.h:16, > from drivers/net/wireless/realtek/rtw88/main.h:8, > from drivers/net/wireless/realtek/rtw88/main.c:5: > drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask': > include/linux/bits.h:23:11: warning: right shift count is negative > [-Wshift-count-negative] > (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) > ^ > drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK' > u64 cfg_mask = GENMASK(63, 0); > ^~~~~~~ > > Reported-by: kbuild test robot <lkp@intel.com> > Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support") > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > Reported-by: kbuild test robot <lkp@intel.com> Patch applied to wireless-drivers-next.git, thanks. 5c70e9714254 rtw88: fix GENMASK_ULL for u64
Kalle Valo <kvalo@codeaurora.org> writes: > <yhchuang@realtek.com> writes: > >> From: Yan-Hsuan Chuang <yhchuang@realtek.com> >> >> This fixes compile warning: >> >> In file included from include/linux/bitops.h:5:0, >> from include/linux/kernel.h:12, >> from include/asm-generic/bug.h:19, >> from arch/mips/include/asm/bug.h:42, >> from include/linux/bug.h:5, >> from include/net/mac80211.h:16, >> from drivers/net/wireless/realtek/rtw88/main.h:8, >> from drivers/net/wireless/realtek/rtw88/main.c:5: >> drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask': >> include/linux/bits.h:23:11: warning: right shift count is negative >> [-Wshift-count-negative] >> (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) >> ^ >> drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK' >> u64 cfg_mask = GENMASK(63, 0); >> ^~~~~~~ >> >> Fixes: f39e9bd49a3d ("rtw88: add set_bitrate_mask support") >> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > > I'll add: > > Reported-by: kbuild test robot <lkp@intel.com> Oh nice, patchwork automatically added the tag from my email above and I didn't have to do anything :)
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index 32e7328ce126..7c1b89c4fb6c 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -627,7 +627,7 @@ static u64 rtw_update_rate_mask(struct rtw_dev *rtwdev, { struct rtw_hal *hal = &rtwdev->hal; const struct cfg80211_bitrate_mask *mask = si->mask; - u64 cfg_mask = GENMASK(63, 0); + u64 cfg_mask = GENMASK_ULL(63, 0); u8 rssi_level, band; if (wireless_set != WIRELESS_CCK) {