cfg80211: Fix memory leak in cfg80211_inform_single_bss_data
diff mbox series

Message ID 20191027180447.8998-1-navid.emamdoost@gmail.com
State Changes Requested
Delegated to: Johannes Berg
Headers show
Series
  • cfg80211: Fix memory leak in cfg80211_inform_single_bss_data
Related show

Commit Message

Navid Emamdoost Oct. 27, 2019, 6:04 p.m. UTC
In the implementation of cfg80211_inform_single_bss_data() the allocated
memory for ies is leaked in case of an error. Release ies if
cfg80211_bss_update() fails.

Fixes: 06aa7afaaa21 ("cfg80211: add cfg80211_inform_bss")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
 net/wireless/scan.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index aef240fdf8df..686eb227bcc3 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1437,8 +1437,10 @@  cfg80211_inform_single_bss_data(struct wiphy *wiphy,
 	signal_valid = abs(data->chan->center_freq - channel->center_freq) <=
 		wiphy->max_adj_channel_rssi_comp;
 	res = cfg80211_bss_update(wiphy_to_rdev(wiphy), &tmp, signal_valid, ts);
-	if (!res)
+	if (!res) {
+		kfree(ies);
 		return NULL;
+	}
 
 	if (channel->band == NL80211_BAND_60GHZ) {
 		bss_type = res->pub.capability & WLAN_CAPABILITY_DMG_TYPE_MASK;