diff mbox series

[rdma-rc] RDMA/mlx5: Return proper error value

Message ID 20191029055721.7192-1-leon@kernel.org (mailing list archive)
State Mainlined
Commit 546d30099ed204792083f043cd7e016de86016a3
Delegated to: Jason Gunthorpe
Headers show
Series [rdma-rc] RDMA/mlx5: Return proper error value | expand

Commit Message

Leon Romanovsky Oct. 29, 2019, 5:57 a.m. UTC 
From: Leon Romanovsky <leonro@mellanox.com>

Returned value from mlx5_mr_cache_alloc() is checked to be error
or real pointer. Return proper error code instead of NULL which
is not checked later.

Fixes: 81713d3788d2 ("IB/mlx5: Add implicit MR support")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/infiniband/hw/mlx5/mr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe Oct. 31, 2019, 6:37 p.m. UTC | #1 
On Tue, Oct 29, 2019 at 07:57:21AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Returned value from mlx5_mr_cache_alloc() is checked to be error
> or real pointer. Return proper error code instead of NULL which
> is not checked later.
> 
> Fixes: 81713d3788d2 ("IB/mlx5: Add implicit MR support")
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  drivers/infiniband/hw/mlx5/mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 7019c12005f4..99d563dba91b 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -428,7 +428,7 @@  struct mlx5_ib_mr *mlx5_mr_cache_alloc(struct mlx5_ib_dev *dev, int entry)
 
 	if (entry < 0 || entry >= MAX_MR_CACHE_ENTRIES) {
 		mlx5_ib_err(dev, "cache entry %d is out of range\n", entry);
-		return NULL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	ent = &cache->ent[entry];