| Message ID | 20191106213055.133424-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 21c60a28af58d7c376502c26fbb0064b39c32917 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: signal completion even on firmware-request failure | expand |
> Subject: [PATCH] rtw88: signal completion even on firmware-request failure > > Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever. > > Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware") > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> > Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Brian Norris <briannorris@chromium.org> wrote: > Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever. > > Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware") > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> > Signed-off-by: Brian Norris <briannorris@chromium.org> > Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com> Patch applied to wireless-drivers-next.git, thanks. 21c60a28af58 rtw88: signal completion even on firmware-request failure
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index de82d08ea29e..ae61415e1665 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -1026,6 +1026,7 @@ static void rtw_load_firmware_cb(const struct firmware *firmware, void *context) if (!firmware || !firmware->data) { rtw_err(rtwdev, "failed to request firmware\n"); + complete_all(&fw->completion); return; }
Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever. Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware") Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/net/wireless/realtek/rtw88/main.c | 1 + 1 file changed, 1 insertion(+)