[1/3] ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources()
diff mbox series

Message ID 87r22c4lub.wl-kuninori.morimoto.gx@renesas.com
State Accepted
Commit 2a6f0892bda954dc2688b002060093ee0fe38528
Headers show
  • ASoC: soc-core cleanup step5+alpha
Related show

Commit Message

Kuninori Morimoto Nov. 13, 2019, 1:16 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

It is easy to read code if it is cleanly using paired function/naming,
like start <-> stop, register <-> unregister, etc, etc.
But, current ALSA SoC code is very random, unbalance, not paired, etc.
It is easy to create bug at the such code, and it will be difficult to

snd_soc_bind_card() is calling snd_soc_dapm_init() for both
card and component.
Let's call paired snd_soc_dapm_shutdown() at paired

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
 sound/soc/soc-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 92260a9..216000a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1953,6 +1953,8 @@  static void soc_cleanup_card_resources(struct snd_soc_card *card)
 		card->snd_card = NULL;
+	snd_soc_dapm_shutdown(card);
 	/* remove and free each DAI */
@@ -2389,7 +2391,6 @@  static void snd_soc_unbind_card(struct snd_soc_card *card, bool unregister)
 	if (card->instantiated) {
 		card->instantiated = false;
-		snd_soc_dapm_shutdown(card);