| Message ID | eefff3bdc564c6cf57fcdaa14e887838aff192cc.1573828743.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Felix Fietkau |
| Headers | show |
| Series | add set_coverage support to mt7615 driver | expand |
On 2019-11-15 16:05, Lorenzo Bianconi wrote: > Fix coverage_class definition in mt76x02_dev data structure since > coverage_class can be negative to enable dynack (just supported by > ath9k) > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> I'd prefer a patch that sets the internal coverage_class field value to 0 for negative input values. - Felix
> On 2019-11-15 16:05, Lorenzo Bianconi wrote: > > Fix coverage_class definition in mt76x02_dev data structure since > > coverage_class can be negative to enable dynack (just supported by > > ath9k) > > > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > I'd prefer a patch that sets the internal coverage_class field value to > 0 for negative input values. ack, I will do in v2 Regards, Lorenzo > > - Felix
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02.h b/drivers/net/wireless/mediatek/mt76/mt76x02.h index 0ca0bbfe8769..cdc1cbd1d392 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x02.h +++ b/drivers/net/wireless/mediatek/mt76/mt76x02.h @@ -110,7 +110,7 @@ struct mt76x02_dev { bool no_2ghz; - u8 coverage_class; + s16 coverage_class; u8 slottime; struct mt76x02_dfs_pattern_detector dfs_pd;
Fix coverage_class definition in mt76x02_dev data structure since coverage_class can be negative to enable dynack (just supported by ath9k) Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/wireless/mediatek/mt76/mt76x02.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)