[3/9] drm/i915/dsb: Turn the "DSB is busy" into an error
diff mbox series

Message ID 20200129182034.26138-3-ville.syrjala@linux.intel.com
State New
Headers show
Series
  • [1/9] drm/i915/dsb: Replace HAS_DSB check with dsb->cmd_buf check
Related show

Commit Message

Ville Syrjälä Jan. 29, 2020, 6:20 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The DSB should never be busy here or we messed up somewhere else.
Make this a DRM_ERROR().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sharma, Swati2 Feb. 3, 2020, 12:36 p.m. UTC | #1
On 29-Jan-20 11:50 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The DSB should never be busy here or we messed up somewhere else.
> Make this a DRM_ERROR().

This is required, at-least to catch the issue in CI.

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index a16a78cd0ebe..5bb4ac1610a5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -52,7 +52,7 @@ static inline bool intel_dsb_enable_engine(struct intel_dsb *dsb)
>   
>   	dsb_ctrl = intel_de_read(dev_priv, DSB_CTRL(pipe, dsb->id));
>   	if (DSB_STATUS & dsb_ctrl) {
> -		DRM_DEBUG_KMS("DSB engine is busy.\n");
> +		DRM_ERROR("DSB engine is busy.\n");
>   		return false;
>   	}
>   
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index a16a78cd0ebe..5bb4ac1610a5 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -52,7 +52,7 @@  static inline bool intel_dsb_enable_engine(struct intel_dsb *dsb)
 
 	dsb_ctrl = intel_de_read(dev_priv, DSB_CTRL(pipe, dsb->id));
 	if (DSB_STATUS & dsb_ctrl) {
-		DRM_DEBUG_KMS("DSB engine is busy.\n");
+		DRM_ERROR("DSB engine is busy.\n");
 		return false;
 	}