| Message ID | 1584956454-8829-2-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: Add new UniPhier PCIe endpoint driver | expand |
On 2020/03/23 18:40, Kunihiko Hayashi wrote: > Add DT bindings for PCIe controller implemented in UniPhier SoCs > when configured in endpoint mode. This controller is based on > the DesignWare PCIe core. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/pci/uniphier-pcie-ep.txt | 53 ++++++++++++++++++++++ > MAINTAINERS | 2 +- > 2 files changed, 54 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt > > diff --git a/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt b/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt > new file mode 100644 > index 0000000..072dc78 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt > @@ -0,0 +1,53 @@ > +Socionext UniPhier PCIe endpoint controller bindings > + > +This describes the devicetree bindings for PCIe endpoint controller > +implemented on Socionext UniPhier SoCs. > + > +UniPhier PCIe endpoint controller is based on the Synopsys DesignWare > +PCI core. It shares common functions with the PCIe DesignWare core driver > +and inherits common properties defined in > +Documentation/devicetree/bindings/pci/designware-pcie.txt. > + > +Required properties: > +- compatible: Should be > + "socionext,uniphier-pro5-pcie-ep" for Pro5 SoC > +- reg: Specifies offset and length of the register set for the device. > + According to the reg-names, appropriate register sets are required. > +- reg-names: Must include the following entries: > + "dbi" - controller configuration registers > + "dbi2" - controller configuration registers for shadow > + "link" - SoC-specific glue layer registers > + "addr_space" - PCIe configuration space > +- clocks: A phandle to the clock gate for PCIe glue layer including > + the endpoint controller. > +- clock-names: Should contain the following: > + "gio", "link" - for Pro5 SoC > +- resets: A phandle to the reset line for PCIe glue layer including > + the endpoint controller. > +- reset-names: Should contain the following: > + "gio", "link" - for Pro5 SoC > + > +Optional properties: > +- phys: A phandle to generic PCIe PHY. According to the phy-names, appropriate > + phys are required. > +- phy-names: Must be "pcie-phy". > + > +Example: > + > + pcie_ep: pcie-ep@66000000 { > + compatible = "socionext,uniphier-pro5-pcie-ep", > + "snps,dw-pcie-ep"; > + status = "disabled"; > + reg-names = "dbi", "dbi2", "link", "addr_space"; > + reg = <0x66000000 0x1000>, <0x66001000 0x1000>, > + <0x66010000 0x10000>, <0x67000000 0x400000>; > + clock-names = "gio", "link"; > + clocks = <&sys_clk 12>, <&sys_clk 24>; > + reset-names = "gio", "link"; > + clocks = <&sys_rst 12>, <&sys_rst 24>; This example contains a mistake. I'll fix it. > + num-ib-windows = <16>; > + num-ob-windows = <16>; > + num-lanes = <4>; > + phy-names = "pcie-phy"; > + phys = <&pcie_phy>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 50e8b90..01a4631 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13151,7 +13151,7 @@ PCIE DRIVER FOR SOCIONEXT UNIPHIER > M: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > L: linux-pci@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/pci/uniphier-pcie.txt > +F: Documentation/devicetree/bindings/pci/uniphier-pcie*.txt > F: drivers/pci/controller/dwc/pcie-uniphier.c > > PCIE DRIVER FOR ST SPEAR13XX > It is my chance to convert this to dt-schema. I'll fix above and send dt-schema version in next. Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt b/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt new file mode 100644 index 0000000..072dc78 --- /dev/null +++ b/Documentation/devicetree/bindings/pci/uniphier-pcie-ep.txt @@ -0,0 +1,53 @@ +Socionext UniPhier PCIe endpoint controller bindings + +This describes the devicetree bindings for PCIe endpoint controller +implemented on Socionext UniPhier SoCs. + +UniPhier PCIe endpoint controller is based on the Synopsys DesignWare +PCI core. It shares common functions with the PCIe DesignWare core driver +and inherits common properties defined in +Documentation/devicetree/bindings/pci/designware-pcie.txt. + +Required properties: +- compatible: Should be + "socionext,uniphier-pro5-pcie-ep" for Pro5 SoC +- reg: Specifies offset and length of the register set for the device. + According to the reg-names, appropriate register sets are required. +- reg-names: Must include the following entries: + "dbi" - controller configuration registers + "dbi2" - controller configuration registers for shadow + "link" - SoC-specific glue layer registers + "addr_space" - PCIe configuration space +- clocks: A phandle to the clock gate for PCIe glue layer including + the endpoint controller. +- clock-names: Should contain the following: + "gio", "link" - for Pro5 SoC +- resets: A phandle to the reset line for PCIe glue layer including + the endpoint controller. +- reset-names: Should contain the following: + "gio", "link" - for Pro5 SoC + +Optional properties: +- phys: A phandle to generic PCIe PHY. According to the phy-names, appropriate + phys are required. +- phy-names: Must be "pcie-phy". + +Example: + + pcie_ep: pcie-ep@66000000 { + compatible = "socionext,uniphier-pro5-pcie-ep", + "snps,dw-pcie-ep"; + status = "disabled"; + reg-names = "dbi", "dbi2", "link", "addr_space"; + reg = <0x66000000 0x1000>, <0x66001000 0x1000>, + <0x66010000 0x10000>, <0x67000000 0x400000>; + clock-names = "gio", "link"; + clocks = <&sys_clk 12>, <&sys_clk 24>; + reset-names = "gio", "link"; + clocks = <&sys_rst 12>, <&sys_rst 24>; + num-ib-windows = <16>; + num-ob-windows = <16>; + num-lanes = <4>; + phy-names = "pcie-phy"; + phys = <&pcie_phy>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 50e8b90..01a4631 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13151,7 +13151,7 @@ PCIE DRIVER FOR SOCIONEXT UNIPHIER M: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> L: linux-pci@vger.kernel.org S: Maintained -F: Documentation/devicetree/bindings/pci/uniphier-pcie.txt +F: Documentation/devicetree/bindings/pci/uniphier-pcie*.txt F: drivers/pci/controller/dwc/pcie-uniphier.c PCIE DRIVER FOR ST SPEAR13XX