| Message ID | 20200331005701.283998-9-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: stm32: Repair AV96 board | expand |
On Tue, Mar 31, 2020 at 02:56:47AM +0200, Marek Vasut wrote: > Add DT node describing the eMMC attached to SDMMC2 controller > of the STM32MP1 on DHCOR SoM, which is the SoM soldered on AV96. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > --- > V2: No change > --- > arch/arm/boot/dts/stm32mp157a-avenger96.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32mp157a-avenger96.dts b/arch/arm/boot/dts/stm32mp157a-avenger96.dts > index 04280353fdbe..6c34a003c3f6 100644 > --- a/arch/arm/boot/dts/stm32mp157a-avenger96.dts > +++ b/arch/arm/boot/dts/stm32mp157a-avenger96.dts > @@ -333,6 +333,21 @@ &sdmmc1 { > status = "okay"; > }; > > +&sdmmc2 { > + pinctrl-names = "default", "opendrain", "sleep"; > + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>; > + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_b>; > + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_b>; > + bus-width = <8>; > + mmc-ddr-1_8v; > + no-sd; > + no-sdio; > + non-removable; > + st,neg-edge; > + vmmc-supply = <&v1v8>; As per the latest schematics, vmmc supply is 3v3 and vqmmc supply is 1v8. With that fixed, Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > + status = "okay"; > +}; > + > &uart4 { > /* On Low speed expansion header */ > label = "LS-UART1"; > -- > 2.25.1 >
On 3/31/20 6:43 AM, Manivannan Sadhasivam wrote: > On Tue, Mar 31, 2020 at 02:56:47AM +0200, Marek Vasut wrote: >> Add DT node describing the eMMC attached to SDMMC2 controller >> of the STM32MP1 on DHCOR SoM, which is the SoM soldered on AV96. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Alexandre Torgue <alexandre.torgue@st.com> >> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> Cc: Patrice Chotard <patrice.chotard@st.com> >> Cc: Patrick Delaunay <patrick.delaunay@st.com> >> Cc: linux-stm32@st-md-mailman.stormreply.com >> To: linux-arm-kernel@lists.infradead.org >> --- >> V2: No change >> --- >> arch/arm/boot/dts/stm32mp157a-avenger96.dts | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm/boot/dts/stm32mp157a-avenger96.dts b/arch/arm/boot/dts/stm32mp157a-avenger96.dts >> index 04280353fdbe..6c34a003c3f6 100644 >> --- a/arch/arm/boot/dts/stm32mp157a-avenger96.dts >> +++ b/arch/arm/boot/dts/stm32mp157a-avenger96.dts >> @@ -333,6 +333,21 @@ &sdmmc1 { >> status = "okay"; >> }; >> >> +&sdmmc2 { >> + pinctrl-names = "default", "opendrain", "sleep"; >> + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>; >> + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_b>; >> + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_b>; >> + bus-width = <8>; >> + mmc-ddr-1_8v; >> + no-sd; >> + no-sdio; >> + non-removable; >> + st,neg-edge; >> + vmmc-supply = <&v1v8>; > > As per the latest schematics, vmmc supply is 3v3 and vqmmc supply is 1v8. > With that fixed, Oh sigh, this actually exposes an issue in mmci driver, thanks for pointing this out.
diff --git a/arch/arm/boot/dts/stm32mp157a-avenger96.dts b/arch/arm/boot/dts/stm32mp157a-avenger96.dts index 04280353fdbe..6c34a003c3f6 100644 --- a/arch/arm/boot/dts/stm32mp157a-avenger96.dts +++ b/arch/arm/boot/dts/stm32mp157a-avenger96.dts @@ -333,6 +333,21 @@ &sdmmc1 { status = "okay"; }; +&sdmmc2 { + pinctrl-names = "default", "opendrain", "sleep"; + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>; + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_b>; + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_b>; + bus-width = <8>; + mmc-ddr-1_8v; + no-sd; + no-sdio; + non-removable; + st,neg-edge; + vmmc-supply = <&v1v8>; + status = "okay"; +}; + &uart4 { /* On Low speed expansion header */ label = "LS-UART1";
Add DT node describing the eMMC attached to SDMMC2 controller of the STM32MP1 on DHCOR SoM, which is the SoM soldered on AV96. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Patrice Chotard <patrice.chotard@st.com> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-arm-kernel@lists.infradead.org --- V2: No change --- arch/arm/boot/dts/stm32mp157a-avenger96.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)