| Message ID | 20200411001933.10072-6-jbi.octave@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 40fb232c02d1b012c6c84b8c22465d01e20eddf9 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | None | expand |
Jules Irenge <jbi.octave@gmail.com> wrote: > Sparse reports a warning at brcms_down() > > warning: context imbalance in brcms_down() > - unexpected unlock > The root cause is the missing annotation at brcms_down() > Add the missing __must_hold(&wl->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Patch applied to wireless-drivers-next.git, thanks. 40fb232c02d1 brcmsmac: Add missing annotation for brcms_down()
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index c3dbeacea6ca..648efcbc819f 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -1431,6 +1431,7 @@ int brcms_up(struct brcms_info *wl) * precondition: perimeter lock has been acquired */ void brcms_down(struct brcms_info *wl) + __must_hold(&wl->lock) { uint callbacks, ret_val = 0;
Sparse reports a warning at brcms_down() warning: context imbalance in brcms_down() - unexpected unlock The root cause is the missing annotation at brcms_down() Add the missing __must_hold(&wl->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 1 + 1 file changed, 1 insertion(+)