| Message ID | 20200420123718.3384-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8af40902f839f5431b89ce2a035ee01e51b31a1d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: remove conversion to bool in ath11k_dp_rxdesc_mpdu_valid() | expand |
Jason Yan <yanaijie@huawei.com> wrote: > The '==' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: > > drivers/net/wireless/ath/ath11k/dp_rx.c:255:46-51: WARNING: conversion > to bool not needed here > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 8af40902f839 ath11k: remove conversion to bool in ath11k_dp_rxdesc_mpdu_valid()
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 203fd44ff352..bbd7da48518f 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -252,7 +252,7 @@ static bool ath11k_dp_rxdesc_mpdu_valid(struct hal_rx_desc *rx_desc) tlv_tag = FIELD_GET(HAL_TLV_HDR_TAG, __le32_to_cpu(rx_desc->mpdu_start_tag)); - return tlv_tag == HAL_RX_MPDU_START ? true : false; + return tlv_tag == HAL_RX_MPDU_START; } static u32 ath11k_dp_rxdesc_get_ppduid(struct hal_rx_desc *rx_desc)
The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/net/wireless/ath/ath11k/dp_rx.c:255:46-51: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)