| Message ID | 20200420123745.4159-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d81709346ceac7b9131b4a091197b9d7fc5a409f |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: remove conversion to bool in ath11k_debug_fw_stats_process() | expand |
Jason Yan <yanaijie@huawei.com> wrote: > The '==' expression itself is bool, no need to convert it to bool again. > This fixes the following coccicheck warning: > > drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion > to bool not needed here > drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion > to bool not needed here > > Signed-off-by: Jason Yan <yanaijie@huawei.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. d81709346cea ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()
diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c index 8d485171b0b3..69db298e16fb 100644 --- a/drivers/net/wireless/ath/ath11k/debug.c +++ b/drivers/net/wireless/ath/ath11k/debug.c @@ -195,7 +195,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb) total_vdevs_started += ar->num_started_vdevs; } - is_end = ((++num_vdev) == total_vdevs_started ? true : false); + is_end = ((++num_vdev) == total_vdevs_started); list_splice_tail_init(&stats.vdevs, &ar->debug.fw_stats.vdevs); @@ -215,7 +215,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb) /* Mark end until we reached the count of all started VDEVs * within the PDEV */ - is_end = ((++num_bcn) == ar->num_started_vdevs ? true : false); + is_end = ((++num_bcn) == ar->num_started_vdevs); list_splice_tail_init(&stats.bcn, &ar->debug.fw_stats.bcn);
The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion to bool not needed here drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/wireless/ath/ath11k/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)