Message ID | 20200526062252.19852-5-f4bug@amsat.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | hw/display: Omnibus cleanups | expand |
On Mon, May 25, 2020 at 11:25 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP), > and add a new one in cirrus_linear_bitblt_read(). > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/display/cirrus_vga.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index 33ccdde000..f9f837b850 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -35,6 +35,7 @@ > #include "qemu/osdep.h" > #include "qemu/module.h" > #include "qemu/units.h" > +#include "qemu/log.h" > #include "sysemu/reset.h" > #include "qapi/error.h" > #include "trace.h" > @@ -905,9 +906,8 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s) > static int cirrus_bitblt_videotocpu(CirrusVGAState * s) > { > /* XXX */ > -#ifdef DEBUG_BITBLT > - printf("cirrus: bitblt (video to cpu) is not implemented yet\n"); > -#endif > + qemu_log_mask(LOG_UNIMP, > + "cirrus: bitblt (video to cpu) is not implemented\n"); > return 0; > } > > @@ -989,9 +989,8 @@ static void cirrus_bitblt_start(CirrusVGAState * s) > cirrus_blt_mode & (CIRRUS_BLTMODE_MEMSYSSRC | > CIRRUS_BLTMODE_MEMSYSDEST)) > == (CIRRUS_BLTMODE_MEMSYSSRC | CIRRUS_BLTMODE_MEMSYSDEST)) { > -#ifdef DEBUG_BITBLT > - printf("cirrus: bitblt - memory-to-memory copy is requested\n"); > -#endif > + qemu_log_mask(LOG_UNIMP, > + "cirrus: bitblt - memory-to-memory copy requested\n"); > goto bitblt_ignore; > } > > @@ -2412,6 +2411,9 @@ static uint64_t cirrus_linear_bitblt_read(void *opaque, > > /* XXX handle bitblt */ > (void)s; > + qemu_log_mask(LOG_UNIMP, > + "cirrus: linear bitblt is not implemented\n"); > + > return 0xff; > } > > -- > 2.21.3 > >
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 33ccdde000..f9f837b850 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -35,6 +35,7 @@ #include "qemu/osdep.h" #include "qemu/module.h" #include "qemu/units.h" +#include "qemu/log.h" #include "sysemu/reset.h" #include "qapi/error.h" #include "trace.h" @@ -905,9 +906,8 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s) static int cirrus_bitblt_videotocpu(CirrusVGAState * s) { /* XXX */ -#ifdef DEBUG_BITBLT - printf("cirrus: bitblt (video to cpu) is not implemented yet\n"); -#endif + qemu_log_mask(LOG_UNIMP, + "cirrus: bitblt (video to cpu) is not implemented\n"); return 0; } @@ -989,9 +989,8 @@ static void cirrus_bitblt_start(CirrusVGAState * s) cirrus_blt_mode & (CIRRUS_BLTMODE_MEMSYSSRC | CIRRUS_BLTMODE_MEMSYSDEST)) == (CIRRUS_BLTMODE_MEMSYSSRC | CIRRUS_BLTMODE_MEMSYSDEST)) { -#ifdef DEBUG_BITBLT - printf("cirrus: bitblt - memory-to-memory copy is requested\n"); -#endif + qemu_log_mask(LOG_UNIMP, + "cirrus: bitblt - memory-to-memory copy requested\n"); goto bitblt_ignore; } @@ -2412,6 +2411,9 @@ static uint64_t cirrus_linear_bitblt_read(void *opaque, /* XXX handle bitblt */ (void)s; + qemu_log_mask(LOG_UNIMP, + "cirrus: linear bitblt is not implemented\n"); + return 0xff; }
Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP), and add a new one in cirrus_linear_bitblt_read(). Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/display/cirrus_vga.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)