| Message ID | 20200526062252.19852-14-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/display: Omnibus cleanups | expand |
On Mon, May 25, 2020 at 11:35 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is > disabled by default. This avoid flooding the terminal when > fuzzing the device. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/display/omap_dss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/omap_dss.c b/hw/display/omap_dss.c > index 32dc0d6aa7..21fde58a26 100644 > --- a/hw/display/omap_dss.c > +++ b/hw/display/omap_dss.c > @@ -619,7 +619,7 @@ static void omap_rfbi_transfer_start(struct omap_dss_s *s) > if (s->rfbi.control & (1 << 1)) { /* BYPASS */ > /* TODO: in non-Bypass mode we probably need to just assert the > * DRQ and wait for DMA to write the pixels. */ > - fprintf(stderr, "%s: Bypass mode unimplemented\n", __func__); > + qemu_log_mask(LOG_UNIMP, "%s: Bypass mode unimplemented\n", __func__); > return; > } > > -- > 2.21.3 > >
diff --git a/hw/display/omap_dss.c b/hw/display/omap_dss.c index 32dc0d6aa7..21fde58a26 100644 --- a/hw/display/omap_dss.c +++ b/hw/display/omap_dss.c @@ -619,7 +619,7 @@ static void omap_rfbi_transfer_start(struct omap_dss_s *s) if (s->rfbi.control & (1 << 1)) { /* BYPASS */ /* TODO: in non-Bypass mode we probably need to just assert the * DRQ and wait for DMA to write the pixels. */ - fprintf(stderr, "%s: Bypass mode unimplemented\n", __func__); + qemu_log_mask(LOG_UNIMP, "%s: Bypass mode unimplemented\n", __func__); return; }
Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is disabled by default. This avoid flooding the terminal when fuzzing the device. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/display/omap_dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)