diff mbox series

[3/3] migration/migration.c: Remove superfluous breaks

Message ID 20200713122345.9289-4-quintela@redhat.com (mailing list archive)
State New, archived
Headers show
Series Migration Pull request | expand

Commit Message

Juan Quintela July 13, 2020, 12:23 p.m. UTC 
From: Liao Pingfang <liao.pingfang@zte.com.cn>

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé July 13, 2020, 12:33 p.m. UTC | #1 
On 7/13/20 2:23 PM, Juan Quintela wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove superfluous breaks, as there is a "return" before them.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

I hadn't reviewed this patch, but now I did ¯\_(ツ)_/¯

> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 08519de56f..2ed9923227 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -986,7 +986,6 @@ static void fill_source_migration_info(MigrationInfo *info)
>          /* no migration has happened ever */
>          /* do not overwrite destination migration status */
>          return;
> -        break;
>      case MIGRATION_STATUS_SETUP:
>          info->has_status = true;
>          info->has_total_time = false;
> @@ -1105,7 +1104,6 @@ static void fill_destination_migration_info(MigrationInfo *info)
>      switch (mis->state) {
>      case MIGRATION_STATUS_NONE:
>          return;
> -        break;
>      case MIGRATION_STATUS_SETUP:
>      case MIGRATION_STATUS_CANCELLING:
>      case MIGRATION_STATUS_CANCELLED:
>
diff mbox series

Patch

diff --git a/migration/migration.c b/migration/migration.c
index 08519de56f..2ed9923227 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -986,7 +986,6 @@  static void fill_source_migration_info(MigrationInfo *info)
         /* no migration has happened ever */
         /* do not overwrite destination migration status */
         return;
-        break;
     case MIGRATION_STATUS_SETUP:
         info->has_status = true;
         info->has_total_time = false;
@@ -1105,7 +1104,6 @@  static void fill_destination_migration_info(MigrationInfo *info)
     switch (mis->state) {
     case MIGRATION_STATUS_NONE:
         return;
-        break;
     case MIGRATION_STATUS_SETUP:
     case MIGRATION_STATUS_CANCELLING:
     case MIGRATION_STATUS_CANCELLED: