diff mbox series

[09/14] drm/i915: Sort KBL PCI IDs

Message ID 20200716172106.2656-10-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: PCI ID cleanup | expand

Commit Message

Ville Syrjälä July 16, 2020, 5:21 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Sort the KBL PCI IDs numerically. Some order seems better than
randomness.

Cc: Alexei Podtelezhnikov <apodtele@gmail.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 include/drm/i915_pciids.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Srivatsa, Anusha Sept. 24, 2020, 12:50 a.m. UTC | #1 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Thursday, July 16, 2020 10:21 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 09/14] drm/i915: Sort KBL PCI IDs
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Sort the KBL PCI IDs numerically. Some order seems better than
> randomness.
> 
> Cc: Alexei Podtelezhnikov <apodtele@gmail.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

> ---
>  include/drm/i915_pciids.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> 5185ac789038..db409171d9c3 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -406,8 +406,8 @@
>  	INTEL_KBL_ULX_GT1_IDS(info), \
>  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
>  	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> -	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> -	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> +	INTEL_VGA_DEVICE(0x590A, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x590B, info) /* Halo GT1 */
> 
>  #define INTEL_KBL_ULT_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \ @@ -419,10
> +419,10 @@
>  #define INTEL_KBL_GT2_IDS(info)	\
>  	INTEL_KBL_ULT_GT2_IDS(info), \
>  	INTEL_KBL_ULX_GT2_IDS(info), \
> -	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> -	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> +	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
>  	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> +	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
>  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> 
>  #define INTEL_KBL_ULT_GT3_IDS(info) \
> --
> 2.26.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 5185ac789038..db409171d9c3 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -406,8 +406,8 @@ 
 	INTEL_KBL_ULX_GT1_IDS(info), \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
 	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
-	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
-	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
+	INTEL_VGA_DEVICE(0x590A, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x590B, info) /* Halo GT1 */
 
 #define INTEL_KBL_ULT_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
@@ -419,10 +419,10 @@ 
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_KBL_ULT_GT2_IDS(info), \
 	INTEL_KBL_ULX_GT2_IDS(info), \
-	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
+	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
 #define INTEL_KBL_ULT_GT3_IDS(info) \