diff mbox

Stable regression 2.6.29.3 vs 2.6.29.2

Message ID 4A258F1C.7030707@kernel.org (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Yinghai Lu June 2, 2009, 8:44 p.m. UTC 
Pascal Terjan wrote:
> Le mardi 02 juin 2009 à 10:24 -0700, Yinghai Lu a écrit :
> ACPI: Using IOAPIC for interrupt routing
> PCI: MCFG configuration 0: base f0000000 segment 0 buses 0 - 255
> PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
> PCI: updated MCFG configuration 0: base f0000000 segment 0 buses 0 - 63
> PCI: Using MMCONFIG for extended config space

please check

[PATCH] x86/pci: fix mmconfig detection with 32bit need 4g

Pascal reported and bisected to commit:
|	x86/PCI: don't call e820_all_mapped with -1 in the mmconfig case

for 32bit, mcfg_res->end could be 32bit only ( if 64 res is not used)
use end - 1 to pass the value in mcfg->end to avoid overflow

don't need to worry about e820 path. they are 64 bit always

Reported-by: Pascal Terjan <pterjan@mandriva.com>
Bisected-by: Pascal Terjan <pterjan@mandriva.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: stable@kernel.org

---
 arch/x86/pci/mmconfig-shared.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Pascal Terjan June 2, 2009, 10:51 p.m. UTC | #1 
Le mardi 02 juin 2009 à 13:44 -0700, Yinghai Lu a écrit :
> Pascal Terjan wrote:
> > Le mardi 02 juin 2009 à 10:24 -0700, Yinghai Lu a écrit :
> > ACPI: Using IOAPIC for interrupt routing
> > PCI: MCFG configuration 0: base f0000000 segment 0 buses 0 - 255
> > PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
> > PCI: updated MCFG configuration 0: base f0000000 segment 0 buses 0 - 63
> > PCI: Using MMCONFIG for extended config space
> 
> please check
> 
> [PATCH] x86/pci: fix mmconfig detection with 32bit need 4g
> 

I confirm that the machine boots fine with 2.6.29.4 + this patch

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yinghai Lu June 2, 2009, 10:54 p.m. UTC | #2 
Pascal Terjan wrote:
> Le mardi 02 juin 2009 à 13:44 -0700, Yinghai Lu a écrit :
>> Pascal Terjan wrote:
>>> Le mardi 02 juin 2009 à 10:24 -0700, Yinghai Lu a écrit :
>>> ACPI: Using IOAPIC for interrupt routing
>>> PCI: MCFG configuration 0: base f0000000 segment 0 buses 0 - 255
>>> PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
>>> PCI: updated MCFG configuration 0: base f0000000 segment 0 buses 0 - 63
>>> PCI: Using MMCONFIG for extended config space
>> please check
>>
>> [PATCH] x86/pci: fix mmconfig detection with 32bit need 4g
>>
> 
> I confirm that the machine boots fine with 2.6.29.4 + this patch

Thanks. Pascal

Can you try that on tip/master too?

http://people.redhat.com/mingo/tip.git/readme.txt

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pascal Terjan June 3, 2009, 9:27 a.m. UTC | #3 
Le mardi 02 juin 2009 à 15:54 -0700, Yinghai Lu a écrit :
> Pascal Terjan wrote:
> > Le mardi 02 juin 2009 à 13:44 -0700, Yinghai Lu a écrit :
> >> Pascal Terjan wrote:
> >>> Le mardi 02 juin 2009 à 10:24 -0700, Yinghai Lu a écrit :
> >>> ACPI: Using IOAPIC for interrupt routing
> >>> PCI: MCFG configuration 0: base f0000000 segment 0 buses 0 - 255
> >>> PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
> >>> PCI: updated MCFG configuration 0: base f0000000 segment 0 buses 0 - 63
> >>> PCI: Using MMCONFIG for extended config space
> >> please check
> >>
> >> [PATCH] x86/pci: fix mmconfig detection with 32bit need 4g
> >>
> > 
> > I confirm that the machine boots fine with 2.6.29.4 + this patch
> 
> Thanks. Pascal
> 
> Can you try that on tip/master too?
> 

It had the bug and the patch fixes it there too

Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: linux-2.6/arch/x86/pci/mmconfig-shared.c
===================================================================
--- linux-2.6.orig/arch/x86/pci/mmconfig-shared.c
+++ linux-2.6/arch/x86/pci/mmconfig-shared.c
@@ -375,7 +375,7 @@  static acpi_status __init check_mcfg_res
 		if (!fixmem32)
 			return AE_OK;
 		if ((mcfg_res->start >= fixmem32->address) &&
-		    (mcfg_res->end <= (fixmem32->address +
+		    (mcfg_res->end < (fixmem32->address +
 				      fixmem32->address_length))) {
 			mcfg_res->flags = 1;
 			return AE_CTRL_TERMINATE;
@@ -392,7 +392,7 @@  static acpi_status __init check_mcfg_res
 		return AE_OK;
 
 	if ((mcfg_res->start >= address.minimum) &&
-	    (mcfg_res->end <= (address.minimum + address.address_length))) {
+	    (mcfg_res->end < (address.minimum + address.address_length))) {
 		mcfg_res->flags = 1;
 		return AE_CTRL_TERMINATE;
 	}
@@ -418,7 +418,7 @@  static int __init is_acpi_reserved(u64 s
 	struct resource mcfg_res;
 
 	mcfg_res.start = start;
-	mcfg_res.end = end;
+	mcfg_res.end = end - 1;
 	mcfg_res.flags = 0;
 
 	acpi_get_devices("PNP0C01", find_mboard_resource, &mcfg_res, NULL);