diff mbox

[3/4] pci: eliminate redundant pci_stop_dev() call from pci_destroy_dev()

Message ID 200906101956.n5AJuWI5009510@imap1.linux-foundation.org (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Andrew Morton June 10, 2009, 7:56 p.m. UTC 
From: Alex Chiang <achiang@hp.com>

We always call pci_stop_bus_device before calling pci_destroy_dev.

Since pci_stop_bus_device calls pci_stop_dev, there is no need
for pci_destroy_dev to repeat the call.

Signed-off-by: Alex Chiang <achiang@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/pci/remove.c |    2 --
 1 file changed, 2 deletions(-)
diff mbox

Patch

diff -puN drivers/pci/remove.c~pci-eliminate-redundant-pci_stop_dev-call-from-pci_destroy_dev drivers/pci/remove.c
--- a/drivers/pci/remove.c~pci-eliminate-redundant-pci_stop_dev-call-from-pci_destroy_dev
+++ a/drivers/pci/remove.c
@@ -32,8 +32,6 @@  static void pci_stop_dev(struct pci_dev 
 
 static void pci_destroy_dev(struct pci_dev *dev)
 {
-	pci_stop_dev(dev);
-
 	/* Remove the device from the device lists, and prevent any further
 	 * list accesses from this device */
 	down_write(&pci_bus_sem);