diff mbox

[1/1] X86: pci quirks, fix pci refcounting

Message ID 1252404978-14977-1-git-send-email-jirislaby@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Jiri Slaby Sept. 8, 2009, 10:16 a.m. UTC 
Stanse found a pci reference leak in quirk_amd_nb_node.
Instead of putting nb_ht, there is a put of dev passed as
an argument.

http://stanse.fi.muni.cz/

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 arch/x86/kernel/quirks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Jesse Barnes Sept. 9, 2009, 9:12 p.m. UTC | #1 
On Tue,  8 Sep 2009 12:16:18 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:

> Stanse found a pci reference leak in quirk_amd_nb_node.
> Instead of putting nb_ht, there is a put of dev passed as
> an argument.
> 
> http://stanse.fi.muni.cz/

Applied to linux-next, thanks.
diff mbox

Patch

diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index af71d06..6c3b2c6 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -508,7 +508,7 @@  static void __init quirk_amd_nb_node(struct pci_dev *dev)
 
 	pci_read_config_dword(nb_ht, 0x60, &val);
 	set_dev_node(&dev->dev, val & 7);
-	pci_dev_put(dev);
+	pci_dev_put(nb_ht);
 }
 
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,