diff mbox

[1/3] mwifiex: Fixed incorrect indentation issue

Message ID 1455173229-6383-1-git-send-email-royujjal@gmail.com (mailing list archive)
State Superseded
Delegated to: Kalle Valo
Headers show

Commit Message

Roy, UjjaL Feb. 11, 2016, 6:47 a.m. UTC
This patch fixes the incorrect indentation of the case label.

Signed-off-by: Ujjal Roy <royujjal@gmail.com>
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kalle Valo Feb. 11, 2016, 9:35 a.m. UTC | #1
Ujjal Roy <royujjal@gmail.com> writes:

> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <royujjal@gmail.com>

A changelog is always recommended to have. Also for some reason your
name in patchwork is all caps:

Submitter       UJJAL ROY

https://patchwork.kernel.org/patch/8276851/

Please try to fix that, but I don't know if that's even possible.
Roy, UjjaL Feb. 11, 2016, 3:02 p.m. UTC | #2
On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Ujjal Roy <royujjal@gmail.com> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter       UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo

I checked that and unable to change the name. If you have any
suggestion please share with me.

Thanks,
UjjaL Roy
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby Feb. 15, 2016, 11:45 p.m. UTC | #3
Hi All,

On Thu, Feb 11, 2016 at 5:47 PM, Ujjal Roy <royujjal@gmail.com> wrote:
> This patch fixes the incorrect indentation of the case label.
>
> Signed-off-by: Ujjal Roy <royujjal@gmail.com>

Looks right to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index e7adef7..cb0cf03 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -676,7 +676,7 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
>                 }
>                 break;
>
> -               case MWIFIEX_BSS_ROLE_STA:
> +       case MWIFIEX_BSS_ROLE_STA:
>                 if (priv->media_connected) {
>                         mwifiex_dbg(adapter, ERROR,
>                                     "cannot change wiphy params when connected");
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roy, UjjaL Feb. 24, 2016, 7:26 p.m. UTC | #4
I have sent all the patches again with my name in CAPITAL letter.
Please have a look.

Thanks,
UjjaL Roy


On Thu, Feb 11, 2016 at 3:05 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Ujjal Roy <royujjal@gmail.com> writes:
>
>> This patch fixes the incorrect indentation of the case label.
>>
>> Signed-off-by: Ujjal Roy <royujjal@gmail.com>
>
> A changelog is always recommended to have. Also for some reason your
> name in patchwork is all caps:
>
> Submitter       UJJAL ROY
>
> https://patchwork.kernel.org/patch/8276851/
>
> Please try to fix that, but I don't know if that's even possible.
>
> --
> Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index e7adef7..cb0cf03 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -676,7 +676,7 @@  mwifiex_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
 		}
 		break;

-		case MWIFIEX_BSS_ROLE_STA:
+	case MWIFIEX_BSS_ROLE_STA:
 		if (priv->media_connected) {
 			mwifiex_dbg(adapter, ERROR,
 				    "cannot change wiphy params when connected");