mac80211_hwsim: Set global RRM capability
diff mbox

Message ID 1456392253-16972-1-git-send-email-emmanuel.grumbach@intel.com
State Rejected
Delegated to: Johannes Berg
Headers show

Commit Message

Emmanuel Grumbach Feb. 25, 2016, 9:24 a.m. UTC
From: David Spinadel <david.spinadel@intel.com>

Allow publishing RRM capabilities for features that are not
HW dependent.

Signed-off-by: David Spinadel <david.spinadel@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 drivers/net/wireless/mac80211_hwsim.c | 1 +
 1 file changed, 1 insertion(+)

Comments

kernel test robot Feb. 25, 2016, 10:01 a.m. UTC | #1
Hi David,

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.5-rc5 next-20160224]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
     wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
                                      ^
   drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in

vim +/NL80211_EXT_FEATURE_RRM +2462 drivers/net/wireless/mac80211_hwsim.c

  2456		hw->wiphy->features |= NL80211_FEATURE_ACTIVE_MONITOR |
  2457				       NL80211_FEATURE_AP_MODE_CHAN_WIDTH_CHANGE |
  2458				       NL80211_FEATURE_STATIC_SMPS |
  2459				       NL80211_FEATURE_DYNAMIC_SMPS |
  2460				       NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
  2461		wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_VHT_IBSS);
> 2462		wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
  2463	
  2464		/* ask mac80211 to reserve space for magic */
  2465		hw->vif_data_size = sizeof(struct hwsim_vif_priv);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Kalle Valo Feb. 26, 2016, 7:17 a.m. UTC | #2
kbuild test robot <lkp@intel.com> writes:

> Hi David,
>
> [auto build test ERROR on wireless-drivers-next/master]
> [also build test ERROR on v4.5-rc5 next-20160224]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> config: sparc64-allyesconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64 
>
> All errors (new ones prefixed by >>):
>
>    drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
>>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
>      wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
>                                       ^
>    drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in

I think this build failure is because mac80211_hwsim is an exception to
other wireless drivers and is applied via mac80211-next. Should we add
an entry for mac80211_hwsim to MAINTAINERS with the correct git tree? I
think kbuild test robot follows MAINTAINERS file nowdays (or at least I
understood that's the plan).
kernel test robot Feb. 26, 2016, 8:18 a.m. UTC | #3
On Fri, Feb 26, 2016 at 09:17:15AM +0200, Kalle Valo wrote:
> kbuild test robot <lkp@intel.com> writes:
> 
> > Hi David,
> >
> > [auto build test ERROR on wireless-drivers-next/master]
> > [also build test ERROR on v4.5-rc5 next-20160224]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> > config: sparc64-allyesconfig (attached as .config)
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=sparc64 
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
> >>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
> >      wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
> >                                       ^
> >    drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in
> 
> I think this build failure is because mac80211_hwsim is an exception to
> other wireless drivers and is applied via mac80211-next. Should we add
> an entry for mac80211_hwsim to MAINTAINERS with the correct git tree? I
> think kbuild test robot follows MAINTAINERS file nowdays (or at least I
> understood that's the plan).

That's right. The robot parses MAINTAINERS when judging which tree
to apply LKML patches to.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg Feb. 26, 2016, 9:47 a.m. UTC | #4
On Fri, 2016-02-26 at 16:18 +0800, Fengguang Wu wrote:

> > I think this build failure is because mac80211_hwsim is an
> > exception to
> > other wireless drivers and is applied via mac80211-next. Should we
> > add
> > an entry for mac80211_hwsim to MAINTAINERS with the correct git
> > tree? I
> > think kbuild test robot follows MAINTAINERS file nowdays (or at
> > least I
> > understood that's the plan).
> 
> That's right. The robot parses MAINTAINERS when judging which tree
> to apply LKML patches to.
> 

Great. I'll add a commit to make mac80211_hwsim just part of the
MAC80211 entry.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg March 2, 2016, 12:24 p.m. UTC | #5
On Thu, 2016-02-25 at 11:24 +0200, Emmanuel Grumbach wrote:
> From: David Spinadel <david.spinadel@intel.com>
> 
> Allow publishing RRM capabilities for features that are not
> HW dependent.

Actually, come to think of it, why don't we do this in mac80211 rather
than the drivers?

The only capability it requires is inserting the IEs, and that's
handled in mac80211.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach March 2, 2016, 12:36 p.m. UTC | #6
PiANCj4gT24gVGh1LCAyMDE2LTAyLTI1IGF0IDExOjI0ICswMjAwLCBFbW1hbnVlbCBHcnVtYmFj
aCB3cm90ZToNCj4gPiBGcm9tOiBEYXZpZCBTcGluYWRlbCA8ZGF2aWQuc3BpbmFkZWxAaW50ZWwu
Y29tPg0KPiA+DQo+ID4gQWxsb3cgcHVibGlzaGluZyBSUk0gY2FwYWJpbGl0aWVzIGZvciBmZWF0
dXJlcyB0aGF0IGFyZSBub3QgSFcNCj4gPiBkZXBlbmRlbnQuDQo+IA0KPiBBY3R1YWxseSwgY29t
ZSB0byB0aGluayBvZiBpdCwgd2h5IGRvbid0IHdlIGRvIHRoaXMgaW4gbWFjODAyMTEgcmF0aGVy
IHRoYW4NCj4gdGhlIGRyaXZlcnM/DQo+IA0KPiBUaGUgb25seSBjYXBhYmlsaXR5IGl0IHJlcXVp
cmVzIGlzIGluc2VydGluZyB0aGUgSUVzLCBhbmQgdGhhdCdzIGhhbmRsZWQgaW4NCj4gbWFjODAy
MTEuDQo+IA0KDQpJIGhhZCB0aGUgc2FtZSB0aGlua2luZywgYnV0IHNvbWVob3cgcGVvcGxlIGNv
bnZpbmNlZCBtZSB0aGF0IGEgZHJpdmVyIG1heSBwcmVmZXIgbm90IHRvIGFkdmVydGlzZSB0aGlz
IHdpdGhvdXQgaXRzIGV4cGxpY2l0IGNvbnNlbnQuIA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg March 3, 2016, 3:45 p.m. UTC | #7
On Wed, 2016-03-02 at 12:36 +0000, Grumbach, Emmanuel wrote:
> > 
> I had the same thinking, but somehow people convinced me that a
> driver may prefer not to advertise this without its explicit
> consent. 

So ... What are the arguments? :)

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach March 4, 2016, 5:39 a.m. UTC | #8
On 03/03/2016 05:45 PM, Johannes Berg wrote:
> On Wed, 2016-03-02 at 12:36 +0000, Grumbach, Emmanuel wrote:
>>>
>> I had the same thinking, but somehow people convinced me that a
>> driver may prefer not to advertise this without its explicit
>> consent.
>
> So ... What are the arguments? :)
>

Well.. a driver may not want to advertise it... Moot...
I guess we can / should move it to mac80211.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index ee37af1..ff45688 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -2458,6 +2458,7 @@  static int mac80211_hwsim_new_radio(struct genl_info *info,
 			       NL80211_FEATURE_DYNAMIC_SMPS |
 			       NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
 	wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_VHT_IBSS);
+	wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
 
 	/* ask mac80211 to reserve space for magic */
 	hw->vif_data_size = sizeof(struct hwsim_vif_priv);