ath10k: Fix legacy rate packet debug messages

Message ID	1463474131-26835-1-git-send-email-mohammed@qca.qualcomm.com (mailing list archive)
State	Accepted
Commit	10bb2d8c85fcf98f0e8e42c912601c3ae86ffdb1
Delegated to:	Kalle Valo
Headers	show Return-Path: <ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> To: <ath10k@lists.infradead.org> Subject: [PATCH] ath10k: Fix legacy rate packet debug messages Date: Tue, 17 May 2016 14:05:31 +0530 Message-ID: <1463474131-26835-1-git-send-email-mohammed@qca.qualcomm.com> MIME-Version: 1.0 Precedence: list Cc: mohammed@codeaurora.org, linux-wireless@vger.kernel.org, Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" <ath10k-bounces@lists.infradead.org> Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org

Message ID

1463474131-26835-1-git-send-email-mohammed@qca.qualcomm.com (mailing list archive)

State

Accepted

Commit

10bb2d8c85fcf98f0e8e42c912601c3ae86ffdb1

Delegated to:

Kalle Valo

Headers

show

Return-Path: <ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org>
X-Original-To: patchwork-ath10k@patchwork.kernel.org
Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.136])
	by patchwork1.web.kernel.org (Postfix) with ESMTP id F2BB99F1C3
	for <patchwork-ath10k@patchwork.kernel.org>;
	Tue, 17 May 2016 08:35:00 +0000 (UTC)
Received: from mail.kernel.org (localhost [127.0.0.1])
	by mail.kernel.org (Postfix) with ESMTP id 2062420303
	for <patchwork-ath10k@patchwork.kernel.org>;
	Tue, 17 May 2016 08:35:00 +0000 (UTC)
Received: from bombadil.infradead.org (bombadil.infradead.org
	[198.137.202.9])
	(using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id EBD9B202DD
	for <patchwork-ath10k@patchwork.kernel.org>;
	Tue, 17 May 2016 08:34:58 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
	by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux))
	id 1b2aSh-0006JB-44; Tue, 17 May 2016 08:34:43 +0000
Received: from wolverine01.qualcomm.com ([199.106.114.254])
	by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat
	Linux)) id 1b2aSe-0006HX-V6
	for ath10k@lists.infradead.org; Tue, 17 May 2016 08:34:41 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
	d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt;
	s=qcdkim; t=1463474080; x=1495010080;
	h=from:to:cc:subject:date:message-id:mime-version;
	bh=FCe7TUbjOTH6jxdF9ej4ihig96KJA62NkXFAC0RknQI=;
	b=gggz73QO7PiiOJDJ3qpDOkkXCmXWr+RisfR2ja0qEYSUEiP+LJVnV4Ln
	coEolD4ZDET1/g874B/cTR9Resy4bWm/5V3whB8PVJFfnyq6TUytzwr11
	kOXHg3p1AqgmSTQYPWh2QvbUP/886Um3+1qe0ETGShANfGqBEXOfrrais w=;
X-IronPort-AV: E=Sophos;i="5.26,324,1459839600"; d="scan'208";a="193664469"
Received: from ironmsg03-r-new.qualcomm.com (HELO Ironmsg03-R.qualcomm.com)
	([10.53.140.107])
	by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA;
	17 May 2016 01:34:19 -0700
From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
X-IronPort-AV: E=McAfee;i="5700,7163,8167"; a="1144101203"
Received: from nasanexm01d.na.qualcomm.com ([10.85.0.84])
	by Ironmsg03-R.qualcomm.com with ESMTP/TLS/RC4-SHA;
	17 May 2016 01:34:19 -0700
Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by
	NASANEXM01D.na.qualcomm.com (10.85.0.84) with Microsoft SMTP Server
	(TLS) id 15.0.1178.4; Tue, 17 May 2016 01:34:18 -0700
Received: from qcmail1.qualcomm.com (10.80.80.8) by
	aphydexm01b.ap.qualcomm.com (10.252.127.11) with Microsoft SMTP
	Server (TLS) id 15.0.1178.4; Tue, 17 May 2016 14:04:10 +0530
Received: by qcmail1.qualcomm.com (sSMTP sendmail emulation);
	Tue, 17 May 2016 14:05:32 +0530
To: <ath10k@lists.infradead.org>
Subject: [PATCH] ath10k: Fix legacy rate packet debug messages
Date: Tue, 17 May 2016 14:05:31 +0530
Message-ID: <1463474131-26835-1-git-send-email-mohammed@qca.qualcomm.com>
X-Mailer: git-send-email 1.9.1
MIME-Version: 1.0
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: NASANEXM01C.na.qualcomm.com (10.85.0.83) To
	aphydexm01b.ap.qualcomm.com (10.252.127.11)
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20160517_013441_211619_F7D6CDCC 
X-CRM114-Status: UNSURE (   7.75  )
X-CRM114-Notice: Please train this message.
X-Spam-Score: -8.4 (--------)
X-BeenThere: ath10k@lists.infradead.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <ath10k.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/ath10k>,
	<mailto:ath10k-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/ath10k/>
List-Post: <mailto:ath10k@lists.infradead.org>
List-Help: <mailto:ath10k-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/ath10k>,
	<mailto:ath10k-request@lists.infradead.org?subject=subscribe>
Cc: mohammed@codeaurora.org, linux-wireless@vger.kernel.org, Mohammed
	Shafi Shajakhan <mohammed@qti.qualcomm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "ath10k" <ath10k-bounces@lists.infradead.org>
Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY
	autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP

Commit Message

Mohammed Shafi Shajakhan May 17, 2016, 8:35 a.m. UTC

From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

Legacy rate packets may not necessarily be having a rx status
flag of '0' always, for example management frame have flags
like RX_FLAG_ONLY_MONITOR / RX_FLAG_MACTIME_END also set

Just check 'VHT' and 'HT' flags are not set , and simply clasify it as
legacy rate packets

Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/htt_rx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo May 24, 2016, 5:55 p.m. UTC | #1

Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> 
> Legacy rate packets may not necessarily be having a rx status
> flag of '0' always, for example management frame have flags
> like RX_FLAG_ONLY_MONITOR / RX_FLAG_MACTIME_END also set
> 
> Just check 'VHT' and 'HT' flags are not set , and simply clasify it as
> legacy rate packets
> 
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

Thanks, 1 patch applied to ath.git:

026441c9d4ff ath10k: fix legacy rate packet debug messages

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index cc979a4..0419a21 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -939,7 +939,8 @@  static void ath10k_process_rx(struct ath10k *ar,
 		   is_multicast_ether_addr(ieee80211_get_DA(hdr)) ?
 							"mcast" : "ucast",
 		   (__le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_SEQ) >> 4,
-		   status->flag == 0 ? "legacy" : "",
+		   (status->flag & (RX_FLAG_HT | RX_FLAG_VHT)) == 0 ?
+							"legacy" : "",
 		   status->flag & RX_FLAG_HT ? "ht" : "",
 		   status->flag & RX_FLAG_VHT ? "vht" : "",
 		   status->flag & RX_FLAG_40MHZ ? "40" : "",

ath10k: Fix legacy rate packet debug messages

Commit Message

Comments

Patch