| Message ID | 1464600795-26307-2-git-send-email-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
Ulf Hansson <ulf.hansson@linaro.org> writes: > The PM core increases the runtime PM usage count at the system PM prepare > phase. Later when the system resumes, it does a pm_runtime_put() in the > complete phase, which in addition to decrementing the usage count, does > the equivalent of a pm_request_idle(). > > Therefore the call to pm_request_idle() from within genpd's ->complete() > callback is redundant, so let's remove it. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Kevin Hilman <khilman@baylibre.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 658eb1b..60a9971 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -938,7 +938,6 @@ static void pm_genpd_complete(struct device *dev) pm_generic_complete(dev); pm_runtime_set_active(dev); pm_runtime_enable(dev); - pm_request_idle(dev); } /**
The PM core increases the runtime PM usage count at the system PM prepare phase. Later when the system resumes, it does a pm_runtime_put() in the complete phase, which in addition to decrementing the usage count, does the equivalent of a pm_request_idle(). Therefore the call to pm_request_idle() from within genpd's ->complete() callback is redundant, so let's remove it. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- Changes in v2: - Updated changelog. --- drivers/base/power/domain.c | 1 - 1 file changed, 1 deletion(-)