diff mbox

[1/6] brcmfmac: fix skb priority handling

Message ID 1464989472-29684-2-git-send-email-arend.vanspriel@broadcom.com (mailing list archive)
State Accepted
Commit 10d096f708e870af7707847bfba3b39fab00c621
Delegated to: Kalle Valo
Headers show

Commit Message

Arend van Spriel June 3, 2016, 9:31 p.m. UTC 
From: Hante Meuleman <hante.meuleman@broadcom.com>

SKBs can come with a prioriy. Currently a priority of 0..7 is
assumed. But this assumption is incorrect. To fix this any
priority of 0 or higher then 7 will be adjusted by calling
cfg80211_classify8021d

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo June 16, 2016, 3:21 p.m. UTC | #1 
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> From: Hante Meuleman <hante.meuleman@broadcom.com>
> 
> SKBs can come with a prioriy. Currently a priority of 0..7 is
> assumed. But this assumption is incorrect. To fix this any
> priority of 0 or higher then 7 will be adjusted by calling
> cfg80211_classify8021d
> 
> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Thanks, 6 patches applied to wireless-drivers-next.git:

10d096f708e8 brcmfmac: fix skb priority handling
d922dfa372ed brcmfmac: revise SDIO error message in brcmf_sdio_drivestrengthinit
cb39288fd6bb brcmfmac: use ndev->needed_headroom to reserve additional header space
43819926eda5 brcmfmac: add support for the PCIE devices 43525 and 43465
98aff6c005e3 brcmfmac: change rx_seq check log from error print to debug print
2a7344510286 brcm80211: update maintainers email addresses
diff mbox

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index 5b30922..cd221ab 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -2101,7 +2101,7 @@  int brcmf_fws_process_skb(struct brcmf_if *ifp, struct sk_buff *skb)
 
 	brcmf_dbg(DATA, "tx proto=0x%X\n", ntohs(eh->h_proto));
 	/* determine the priority */
-	if (!skb->priority)
+	if ((skb->priority == 0) || (skb->priority > 7))
 		skb->priority = cfg80211_classify8021d(skb, NULL);
 
 	drvr->tx_multicast += !!multicast;