| Message ID | 1470641928-26616-1-git-send-email-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ba852018d493c99d3183fdcc7e41b725f2ec1321 |
| Delegated to: | Kalle Valo |
| Headers | show |
Christophe Jaillet <christophe.jaillet@wanadoo.fr> wrote: > In 'mwifiex_get_ver_ext', we have: > struct mwifiex_ver_ext ver_ext; > > memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); > > This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. > Remove the ambiguity by using the variable name directly instead of its > type. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks, 2 patches applied to wireless-drivers-next.git: ba852018d493 mwifiex: fix the length parameter of a memset 6a1622000ac9 mwifiex: simplify length computation for some memset
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c index e06647a..78819e8 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c @@ -1180,7 +1180,7 @@ mwifiex_get_ver_ext(struct mwifiex_private *priv, u32 version_str_sel) { struct mwifiex_ver_ext ver_ext; - memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); + memset(&ver_ext, 0, sizeof(ver_ext)); ver_ext.version_str_sel = version_str_sel; if (mwifiex_send_cmd(priv, HostCmd_CMD_VERSION_EXT, HostCmd_ACT_GEN_GET, 0, &ver_ext, true))
In 'mwifiex_get_ver_ext', we have: struct mwifiex_ver_ext ver_ext; memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. Remove the ambiguity by using the variable name directly instead of its type. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)