diff mbox

x86/PCI: reduce severity of host bridge window conflict warnings

Message ID 20110702164712.21109.66511.stgit@bhelgaas.mtv.corp.google.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Bjorn Helgaas July 2, 2011, 4:47 p.m. UTC
Host bridge windows are top-level resources, so if we find a host bridge
window conflict, it's probably with a hard-coded legacy reservation.
Moving host bridge windows is theoretically possible, but we don't support
it; we just ignore windows with conflicts, and it's not worth making this
a user-visible error.

Reported-and-tested-by: Jools Wills <jools@oxfordinspire.co.uk>
References: https://bugzilla.kernel.org/show_bug.cgi?id=38522
Reported-by: Das <dasfox@gmail.com>
References: https://bugzilla.kernel.org/show_bug.cgi?id=16497
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/x86/pci/acpi.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jesse Barnes July 22, 2011, 3:24 p.m. UTC | #1
On Sat, 02 Jul 2011 10:47:12 -0600
Bjorn Helgaas <bhelgaas@google.com> wrote:

> Host bridge windows are top-level resources, so if we find a host bridge
> window conflict, it's probably with a hard-coded legacy reservation.
> Moving host bridge windows is theoretically possible, but we don't support
> it; we just ignore windows with conflicts, and it's not worth making this
> a user-visible error.
> 
> Reported-and-tested-by: Jools Wills <jools@oxfordinspire.co.uk>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=38522
> Reported-by: Das <dasfox@gmail.com>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=16497
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---

Applied, thanks.
diff mbox

Patch

diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 68c3c13..ae3cb23 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x86/pci/acpi.c
@@ -246,10 +246,9 @@  static void add_resources(struct pci_root_info *info)
 
 		conflict = insert_resource_conflict(root, res);
 		if (conflict)
-			dev_err(&info->bridge->dev,
-				"address space collision: host bridge window %pR "
-				"conflicts with %s %pR\n",
-				res, conflict->name, conflict);
+			dev_info(&info->bridge->dev,
+				 "ignoring host bridge window %pR (conflicts with %s %pR)\n",
+				 res, conflict->name, conflict);
 		else
 			pci_bus_add_resource(info->bus, res, 0);
 	}