| Message ID | 196e46eee00fd3ebb56da1373c36f3dff66f2ae1.1479974100.git.kirtika@chromium.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Kirtika Ruchandani <kirtika.ruchandani@gmail.com> wrote: > Commit 32653cf19554 removed the call to 'skb_trim(skb, buf_len)' > in ath10k_wmi_event_mgmt_rx(), leaving the buf_len variable set but > unused. Compiling with W=1 gives the following warning, fix it. > drivers/net/wireless/ath/ath10k/wmi.c: In function ‘ath10k_wmi_event_mgmt_rx’: > drivers/net/wireless/ath/ath10k/wmi.c:2280:6: warning: variable ‘buf_len’ set but not used [-Wunused-but-set-variable] > > This is a harmless warning, and is only being fixed to reduce the > noise with W=1 in the kernel. > > Fixes: 32653cf19554 ("ath10k: implement intermediate event args") > Cc: Michal Kazior <michal.kazior@tieto.com> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org> These patches seem to be corrupted: Applying: ath10k: Remove unused 'buf_len' variable fatal: corrupt patch at line 13 error: could not build fake ancestor Patch failed at 0001 ath10k: Remove unused 'buf_len' variable When resending please also cc ath10k list: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches 4 patches set to Changes Requested. 9444973 [1/5] ath10k: Remove unused 'buf_len' variable 9444935 [2/5] ath10k: Remove unused 'num_vdev_stats' variable 9444971 [4/5] ath10k: Removed unused 'dev' in ath10k_ahb_clock_enable() 9444975 [5/5] ath10k: Removed unused 'dev' in ath10k_ahb_resource_init
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 387c4ee..1f28187 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2277,7 +2277,6 @@ int ath10k_wmi_event_mgmt_rx(struct ath10k *ar, struct sk_buff *skb) u32 phy_mode; u32 snr; u32 rate; - u32 buf_len; u16 fc; int ret; @@ -2289,7 +2288,6 @@ int ath10k_wmi_event_mgmt_rx(struct ath10k *ar, struct sk_buff *skb) } channel = __le32_to_cpu(arg.channel); - buf_len = __le32_to_cpu(arg.buf_len); rx_status = __le32_to_cpu(arg.status); snr = __le32_to_cpu(arg.snr); phy_mode = __le32_to_cpu(arg.phy_mode);
Commit 32653cf19554 removed the call to 'skb_trim(skb, buf_len)' in ath10k_wmi_event_mgmt_rx(), leaving the buf_len variable set but unused. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/wmi.c: In function ‘ath10k_wmi_event_mgmt_rx’: drivers/net/wireless/ath/ath10k/wmi.c:2280:6: warning: variable ‘buf_len’ set but not used [-Wunused-but-set-variable] This is a harmless warning, and is only being fixed to reduce the noise with W=1 in the kernel. Fixes: 32653cf19554 ("ath10k: implement intermediate event args") Cc: Michal Kazior <michal.kazior@tieto.com> Cc: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org> --- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 1 file changed, 2 deletions(-) -- 2.8.0.rc3.226.g39d4020