| Message ID | 375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/11/2017 05:55 PM, Cameron Gutman wrote: > > The affected machine is an XPS 13 9443 running Fedora 25 with 4.11-rc1 > and libinput 1.6.3-3.fc25 (latest in F25). > Oops, that's 9343, not 9443. DMI: Dell Inc. XPS 13 9343/0TM99H, BIOS A11 12/08/2016 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Lo! On 12.03.2017 02:55, Cameron Gutman wrote: > > Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9343's > Synaptics touchpad and dropping some errors into dmesg. Here are the > messages that seem RMI-related: > > rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version > rmi4_f34: probe of rmi4-00.fn34 failed with error -22 > rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324 > input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19 > hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01 FWIW, I get this on my XPS 13 DE (9360) with 4.11-rc1: input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio1/input/input6 rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version rmi4_f34: probe of rmi4-00.fn34 failed with error -22 rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-003, fw id: 2375007 input: Synaptics TM3038-003 as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-8/i2c-DLL075B:01/0018:06CB:76AF.0001/input/input20 hid-rmi 0018:06CB:76AF.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL075B:01 06CB:76AF] on i2c-DLL075B:01 > […] > Compared to hid-multitouch, the RMI stack seems to have completely broken > palm rejection and introduced some random jumpiness during fine pointing > motions. I don't know if these issues are caused by the above errors or > are a separate issue. Just to confirm: I noticed "jumpiness during fine pointing motions" as well since switching to 4.11-rc. @benjamin: Just wondering: Could that have something to do with the ps2->rmi handover? I noticed that patches to improve things in this area are still circulating, which lead me to wonder if that might have anything to do with this. But it's just a wild guess. > The affected machine is an XPS 13 9343 running Fedora 25 with 4.11-rc1 > and libinput 1.6.3-3.fc25 (latest in F25). Same setup here. In case it matters: I'm running Gnome-Shell in Wayland mode. Ciao, Thorsten P.S.: I fixed the model number in above quotes from Cameron to avoid confusion (he has a 9343, and not a 9443, as initially stated; see a different mail in this thread for details) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote: > Lo! On 12.03.2017 02:55, Cameron Gutman wrote: > > > > Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9343's > > Synaptics touchpad and dropping some errors into dmesg. Here are the > > messages that seem RMI-related: > > > > rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version > > rmi4_f34: probe of rmi4-00.fn34 failed with error -22 > > rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324 > > input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19 > > hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01 > > FWIW, I get this on my XPS 13 DE (9360) with 4.11-rc1: > > input: SynPS/2 Synaptics TouchPad as > /devices/platform/i8042/serio1/input/input6 > rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version > rmi4_f34: probe of rmi4-00.fn34 failed with error -22 > rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, > product: TM3038-003, fw id: 2375007 > input: Synaptics TM3038-003 as > /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-8/i2c-DLL075B:01/0018:06CB:76AF.0001/input/input20 > hid-rmi 0018:06CB:76AF.0001: input,hidraw0: I2C HID v1.00 Mouse > [DLL075B:01 06CB:76AF] on i2c-DLL075B:01 > > > […] > > Compared to hid-multitouch, the RMI stack seems to have completely broken > > palm rejection and introduced some random jumpiness during fine pointing > > motions. I don't know if these issues are caused by the above errors or > > are a separate issue. > > Just to confirm: I noticed "jumpiness during fine pointing motions" as > well since switching to 4.11-rc. Thanks both of you for the reports. Andrew, Jiri, I think switching everybody to rmi4-core was maybe not the best move. Could we add a module parameter somewhere to force switching back to hid-multitouch? (Or the other way around more likely). We might need to have users testing rmi4-core and report libinput bugs, but introducing such regressions for everybody is IMO not the right way. Note that I do not see any differences besides bug fixes when switching from PS/2 to RMI4-core on my Lenovo T450s, so maybe the hid-multitouch capable firmware does some more filtering (the Lenovos are not using HID for the touchpads). > > @benjamin: Just wondering: Could that have something to do with the > ps2->rmi handover? I noticed that patches to improve things in this area > are still circulating, which lead me to wonder if that might have > anything to do with this. But it's just a wild guess. This has nothing to do. ps2->rmi is not used at all by hid-rmi as the enumeration is done in the ACPI. The series you are mentioning are for touchpads that do not enumerate. Once enumerated (either through PS/2 or HID), the code should be the same. Cheers, Benjamin > > > The affected machine is an XPS 13 9343 running Fedora 25 with 4.11-rc1 > > and libinput 1.6.3-3.fc25 (latest in F25). > > Same setup here. In case it matters: I'm running Gnome-Shell in Wayland > mode. > > Ciao, Thorsten > > P.S.: I fixed the model number in above quotes from Cameron to avoid > confusion (he has a 9343, and not a 9443, as initially stated; see a > different mail in this thread for details) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Resending, forgot to add Jiri in CC] On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote: > On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote: > > Lo! On 12.03.2017 02:55, Cameron Gutman wrote: > > > > > > Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9343's > > > Synaptics touchpad and dropping some errors into dmesg. Here are the > > > messages that seem RMI-related: > > > > > > rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version > > > rmi4_f34: probe of rmi4-00.fn34 failed with error -22 > > > rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324 > > > input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19 > > > hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01 > > > > FWIW, I get this on my XPS 13 DE (9360) with 4.11-rc1: > > > > input: SynPS/2 Synaptics TouchPad as > > /devices/platform/i8042/serio1/input/input6 > > rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version > > rmi4_f34: probe of rmi4-00.fn34 failed with error -22 > > rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, > > product: TM3038-003, fw id: 2375007 > > input: Synaptics TM3038-003 as > > /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-8/i2c-DLL075B:01/0018:06CB:76AF.0001/input/input20 > > hid-rmi 0018:06CB:76AF.0001: input,hidraw0: I2C HID v1.00 Mouse > > [DLL075B:01 06CB:76AF] on i2c-DLL075B:01 > > > > > […] > > > Compared to hid-multitouch, the RMI stack seems to have completely broken > > > palm rejection and introduced some random jumpiness during fine pointing > > > motions. I don't know if these issues are caused by the above errors or > > > are a separate issue. > > > > Just to confirm: I noticed "jumpiness during fine pointing motions" as > > well since switching to 4.11-rc. > > Thanks both of you for the reports. > Andrew, Jiri, I think switching everybody to rmi4-core was maybe not the > best move. Could we add a module parameter somewhere to force switching > back to hid-multitouch? (Or the other way around more likely). > > We might need to have users testing rmi4-core and report libinput bugs, > but introducing such regressions for everybody is IMO not the right way. > > Note that I do not see any differences besides bug fixes when switching > from PS/2 to RMI4-core on my Lenovo T450s, so maybe the hid-multitouch > capable firmware does some more filtering (the Lenovos are not using HID > for the touchpads). > > > > > @benjamin: Just wondering: Could that have something to do with the > > ps2->rmi handover? I noticed that patches to improve things in this area > > are still circulating, which lead me to wonder if that might have > > anything to do with this. But it's just a wild guess. > > This has nothing to do. ps2->rmi is not used at all by hid-rmi as the > enumeration is done in the ACPI. The series you are mentioning are for > touchpads that do not enumerate. Once enumerated (either through PS/2 or > HID), the code should be the same. > > Cheers, > Benjamin > > > > > > The affected machine is an XPS 13 9343 running Fedora 25 with 4.11-rc1 > > > and libinput 1.6.3-3.fc25 (latest in F25). > > > > Same setup here. In case it matters: I'm running Gnome-Shell in Wayland > > mode. > > > > Ciao, Thorsten > > > > P.S.: I fixed the model number in above quotes from Cameron to avoid > > confusion (he has a 9343, and not a 9443, as initially stated; see a > > different mail in this thread for details) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c index 56c6c39..b458cb3 100644 --- a/drivers/input/rmi4/rmi_f34v7.c +++ b/drivers/input/rmi4/rmi_f34v7.c @@ -1369,8 +1369,8 @@ int rmi_f34v7_probe(struct f34_data *f34) } else if (f34->bootloader_id[1] == 7) { f34->bl_version = 7; } else { - dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version\n", - __func__); + dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version: %u\n", + __func__, f34->bootloader_id[1]); return -EINVAL; } -- To unsubscribe from this list: send the line "unsubscribe linux-input" in