| Message ID | b8db3326-5f45-04c0-a6c3-d5183d602e8d@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c6c092dcb21e4def00f2b5e077d03434c38acfe4 |
| Delegated to: | Kalle Valo |
| Headers | show |
On Wed, 17 May 2017 18:22:49 +0200 SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 May 2017 18:12:16 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/ssb/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > index d1a750760cf3..65420a9f0e82 100644 > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus) > > devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL); > if (!devwrap) { > - ssb_err("Could not allocate device\n"); > err = -ENOMEM; > goto error; > } This looks good. Acked-by: Michael Büsch <m@bues.ch>
SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 May 2017 18:12:16 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > Acked-by: Michael Büsch <m@bues.ch> Patch applied to wireless-drivers-next.git, thanks. c6c092dcb21e ssb: Delete an error message for a failed memory allocation in ssb_devices_register()
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index d1a750760cf3..65420a9f0e82 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus) devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL); if (!devwrap) { - ssb_err("Could not allocate device\n"); err = -ENOMEM; goto error; }