diff mbox

[v2,5/8] staging: wilc1000: Add new variable for ac queue management

Message ID 1498477410-19518-6-git-send-email-aditya.shankar@microchip.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Aditya.Shankar@microchip.com June 26, 2017, 11:43 a.m. UTC
This patch adds a new variable in the wilc struct to manage
ac queues.

Signed-off-by: Aditya Shankar <aditya.shankar@microchip.com>
---
 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg Kroah-Hartman June 29, 2017, 2:38 p.m. UTC | #1
On Mon, Jun 26, 2017 at 05:13:27PM +0530, Aditya Shankar wrote:
> This patch adds a new variable in the wilc struct to manage
> ac queues.
> 
> Signed-off-by: Aditya Shankar <aditya.shankar@microchip.com>
> ---
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
>  1 file changed, 1 insertion(+)

Wait, what is this whole patch series for?  You are adding functions and
variables and not using this functionality at all!  Why are you adding
new functionality to the driver now, and not working to get it out of
staging instead?

I'm going to go drop these patches from the tree now...

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000/wilc_wfi_netdevice.h
index c89bf43..e830bc5 100644
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h
@@ -200,6 +200,7 @@  struct wilc {
 
 	struct txq_entry_t *txq_head;
 	struct txq_entry_t *txq_tail;
+	struct txq_handle txq[NQUEUES];
 	int txq_entries;
 	int txq_exit;