| Message ID | 1501753079-1758-1-git-send-email-wright.feng@cypress.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fdfb0f94bfb71ce31f5417b2f6362e43b0b847f0 |
| Delegated to: | Kalle Valo |
| Headers | show |
Wright Feng <wright.feng@cypress.com> writes: > brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode > > When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, > firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and > probe response. The security type in softAP beacons confuse the > supplicant in client side, and the user client will see [WPA-?] in > supplicant scan result. So we set WPA_AUTH_DISABLED in softAP mode with > OPEN security. The title is now duplicated, it's now in Subject and in the body, but I can fix that.
On 8/3/2017 11:37 AM, Wright Feng wrote: > brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode > > When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, > firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and > probe response. The security type in softAP beacons confuse the > supplicant in client side, and the user client will see [WPA-?] in > supplicant scan result. So we set WPA_AUTH_DISABLED in softAP mode with > OPEN security. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Wright Feng <wright.feng@cypress.com> > --- > v2: fix typo in commit message > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-)
Wright Feng <wright.feng@cypress.com> wrote: > When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, > firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and > probe response. The security type in softAP beacons confuse the > supplicant in client side, and the user client will see [WPA-?] in > supplicant scan result. So we set WPA_AUTH_DISABLED in softAP mode with > OPEN security. > > Signed-off-by: Wright Feng <wright.feng@cypress.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> 3 patches applied to wireless-drivers-next.git, thanks. fdfb0f94bfb7 brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode 0ec9eb90feec brcmfmac: Add support for CYW4373 SDIO/USB chipset 99976fc08412 brcmfmac: fix wrong num_different_channels when mchan feature enabled
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 2f8776f..0281a22 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -3854,6 +3854,7 @@ static s32 brcmf_cfg80211_suspend(struct wiphy *wiphy, static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp) { s32 err; + s32 wpa_val; /* set auth */ err = brcmf_fil_bsscfg_int_set(ifp, "auth", 0); @@ -3868,7 +3869,11 @@ static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp) return err; } /* set upper-layer auth */ - err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", WPA_AUTH_NONE); + if (brcmf_is_ibssmode(ifp->vif)) + wpa_val = WPA_AUTH_NONE; + else + wpa_val = WPA_AUTH_DISABLED; + err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", wpa_val); if (err < 0) { brcmf_err("wpa_auth error %d\n", err); return err;
brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security, firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and probe response. The security type in softAP beacons confuse the supplicant in client side, and the user client will see [WPA-?] in supplicant scan result. So we set WPA_AUTH_DISABLED in softAP mode with OPEN security. Signed-off-by: Wright Feng <wright.feng@cypress.com> --- v2: fix typo in commit message --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)