| Message ID | 20210418134658.4333-1-david.ward@gatech.edu (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack | expand |
On 4/18/21 8:46 AM, David Ward wrote: > The last two patches in this series fix a longstanding issue that prevented > the ALC3263 codec from using a headset mic. This codec can be found on Dell > systems including the Latitude 13 7350, Venue 11 Pro 7140, and XPS 13 9343. > In fact, there is an ACPI quirk for the XPS 13 9343, which forces it to use > legacy HD Audio just to avoid this issue: > > https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com/ > > This may allow that ACPI quirk to be removed. Either way, the other systems > mentioned above do not support this quirk and already use the ASoC driver, > so this fix is necessary for headset mic support on those systems. You should probably add a Fixes tag for the 5 patches so that the changes make their way into the -stable kernel that most distributions use? The patches themselves look ok to me Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > Note: there is likely other handling for this codec that only exists in the > HDA driver, but which also belongs in the ASoC driver. Commit 394c97f824fa > ("ALSA: hda/realtek - Change EAPD to verb control") describes an issue that > does not seem to be resolved in the ASoC driver, to give an example. > > > Other patches in this series are not specific to the ALC3263. These patches > set the correct combo jack configuration when headphones are inserted, and > fix a misaligned value set in the DMIC2 Configuration Default register. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171 > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=150601 > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205961 > Signed-off-by: David Ward <david.ward@gatech.edu> > > David Ward (5): > ASoC: rt286: Fix upper byte in DMIC2 configuration > ASoC: rt286: Configure combo jack for headphones > ASoC: rt298: Configure combo jack for headphones > ASoC: rt286: Make RT286_SET_GPIO_* readable and writable > ASoC: rt286: Generalize support for ALC3263 codec > > sound/soc/codecs/rt286.c | 34 +++++++++++++++++++++------------- > sound/soc/codecs/rt298.c | 9 +++++++-- > 2 files changed, 28 insertions(+), 15 deletions(-) >
On Sun, 18 Apr 2021 09:46:53 -0400, David Ward wrote: > The last two patches in this series fix a longstanding issue that prevented > the ALC3263 codec from using a headset mic. This codec can be found on Dell > systems including the Latitude 13 7350, Venue 11 Pro 7140, and XPS 13 9343. > In fact, there is an ACPI quirk for the XPS 13 9343, which forces it to use > legacy HD Audio just to avoid this issue: > > https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com/ > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: rt286: Fix upper byte in DMIC2 configuration commit: dfa7b01dbdc9723ced606425b47005bb583a8778 [2/5] ASoC: rt286: Configure combo jack for headphones commit: b15c3ea7e0d2c53b33adc8ca0896de378d6df853 [3/5] ASoC: rt298: Configure combo jack for headphones commit: f3bd4dde9f048fa711e98626c8c3bc4d1eae3436 [4/5] ASoC: rt286: Make RT286_SET_GPIO_* readable and writable commit: cd8499d5c03ba260e3191e90236d0e5f6b147563 [5/5] ASoC: rt286: Generalize support for ALC3263 codec commit: aa2f9c12821e6a4ba1df4fb34a3dbc6a2a1ee7fe All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
The last two patches in this series fix a longstanding issue that prevented the ALC3263 codec from using a headset mic. This codec can be found on Dell systems including the Latitude 13 7350, Venue 11 Pro 7140, and XPS 13 9343. In fact, there is an ACPI quirk for the XPS 13 9343, which forces it to use legacy HD Audio just to avoid this issue: https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com/ This may allow that ACPI quirk to be removed. Either way, the other systems mentioned above do not support this quirk and already use the ASoC driver, so this fix is necessary for headset mic support on those systems. Note: there is likely other handling for this codec that only exists in the HDA driver, but which also belongs in the ASoC driver. Commit 394c97f824fa ("ALSA: hda/realtek - Change EAPD to verb control") describes an issue that does not seem to be resolved in the ASoC driver, to give an example. Other patches in this series are not specific to the ALC3263. These patches set the correct combo jack configuration when headphones are inserted, and fix a misaligned value set in the DMIC2 Configuration Default register. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=150601 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205961 Signed-off-by: David Ward <david.ward@gatech.edu> David Ward (5): ASoC: rt286: Fix upper byte in DMIC2 configuration ASoC: rt286: Configure combo jack for headphones ASoC: rt298: Configure combo jack for headphones ASoC: rt286: Make RT286_SET_GPIO_* readable and writable ASoC: rt286: Generalize support for ALC3263 codec sound/soc/codecs/rt286.c | 34 +++++++++++++++++++++------------- sound/soc/codecs/rt298.c | 9 +++++++-- 2 files changed, 28 insertions(+), 15 deletions(-)