mbox series

[v2,0/4] ALSA: firewire-lib: drop initial NODATA packets or empty packets

Message ID 20210524031346.50539-1-o-takashi@sakamocchi.jp (mailing list archive)
Headers show
Series ALSA: firewire-lib: drop initial NODATA packets or empty packets | expand

Message

Takashi Sakamoto May 24, 2021, 3:13 a.m. UTC 
Hi,

This patchset is take 2 of my previous one;
 * https://lore.kernel.org/alsa-devel/20210523124114.272134-1-o-takashi@sakamocchi.jp/

The devices based on BeBoB ASICs or the devices in Tascam FireWire
series transfer a batch of NODATA packet or empty packet in initial step
of streaming. To avoid processing them, current implementation uses an
option to skip processing content of tx packet during some initial
cycles. However, the hard-coded number is not enough useful.

In 1st patch, ALSA IEC 61883-1/6 packet streaming engine becomes to drop
the initial packets. As a result, The tx_init_skip_cycles argument of
amdtp_domain_start() function changes its meaning. In the following
patches, ALSA bebob driver is refactored.

Changes from v1:
 * Fix -Wunused-but-set-variable warning reported by 0day-ci
 * Add 2nd patch to obsolete unused member of structure

Takashi Sakamoto (4):
  ALSA: firewire-lib: drop initial NODATA or empty packet
  ALSA: firewire-lib: obsolete callbacked member
  ALSA: bebob: cancel switching connection order
  ALSA: bebob: distinguish M-Audio ProFire Lightbridge quirk

 sound/firewire/amdtp-stream.c       | 145 +++++++++++++++++++---------
 sound/firewire/amdtp-stream.h       |   6 +-
 sound/firewire/bebob/bebob.c        |  10 +-
 sound/firewire/bebob/bebob.h        |   1 +
 sound/firewire/bebob/bebob_stream.c |  25 ++---
 5 files changed, 122 insertions(+), 65 deletions(-)

Comments

Takashi Iwai May 25, 2021, 6:55 a.m. UTC | #1 
On Mon, 24 May 2021 05:13:42 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> This patchset is take 2 of my previous one;
>  * https://lore.kernel.org/alsa-devel/20210523124114.272134-1-o-takashi@sakamocchi.jp/
> 
> The devices based on BeBoB ASICs or the devices in Tascam FireWire
> series transfer a batch of NODATA packet or empty packet in initial step
> of streaming. To avoid processing them, current implementation uses an
> option to skip processing content of tx packet during some initial
> cycles. However, the hard-coded number is not enough useful.
> 
> In 1st patch, ALSA IEC 61883-1/6 packet streaming engine becomes to drop
> the initial packets. As a result, The tx_init_skip_cycles argument of
> amdtp_domain_start() function changes its meaning. In the following
> patches, ALSA bebob driver is refactored.
> 
> Changes from v1:
>  * Fix -Wunused-but-set-variable warning reported by 0day-ci
>  * Add 2nd patch to obsolete unused member of structure
> 
> Takashi Sakamoto (4):
>   ALSA: firewire-lib: drop initial NODATA or empty packet
>   ALSA: firewire-lib: obsolete callbacked member
>   ALSA: bebob: cancel switching connection order
>   ALSA: bebob: distinguish M-Audio ProFire Lightbridge quirk

Applied all four patches now.  Thanks.


Takashi