| Message ID | 20240501113445.100817-1-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | ALSA: pcm: obsolete sync member in runtime structure | expand |
On 01. 05. 24 13:34, Takashi Sakamoto wrote: > Hi, > > Seven years ago, in Linux kernel version 4.13, the data of > snd_pcm_sync_id union is not exposed to user space anymore, by a commit > e11f0f90a626 ("ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command"). >>From then, we have received no issued related to it. It means that the > data is neither used by any practical applications nor drivers, thus it > can be removed. > > This series of change is to obsolete the usage of the union data > in PCM core function. The kernel API, snd_pcm_set_sync(), is removed. > and the 'sync' member of snd_pcm_runtime structure is removed. Finally, > some notes are added to UAPI header. > > The removal of sync field has a side effect for emu10k driver, since p16v > chip code sets the data by hand. Its removal requires any deliberate > discussion, but the calm in seven years would satisfy the condition of > it. > > > The patch comment sent by Jaroslav[1] refers to the reinvention of the > union data, but as the part of hardware configuration step. If it > proceeds, the UAPI note would be modified simply. Strong NAK until we have another API replacement. Jaroslav
Hi, Seven years ago, in Linux kernel version 4.13, the data of snd_pcm_sync_id union is not exposed to user space anymore, by a commit e11f0f90a626 ("ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command"). From then, we have received no issued related to it. It means that the data is neither used by any practical applications nor drivers, thus it can be removed. This series of change is to obsolete the usage of the union data in PCM core function. The kernel API, snd_pcm_set_sync(), is removed. and the 'sync' member of snd_pcm_runtime structure is removed. Finally, some notes are added to UAPI header. The removal of sync field has a side effect for emu10k driver, since p16v chip code sets the data by hand. Its removal requires any deliberate discussion, but the calm in seven years would satisfy the condition of it. The patch comment sent by Jaroslav[1] refers to the reinvention of the union data, but as the part of hardware configuration step. If it proceeds, the UAPI note would be modified simply. [1] https://lore.kernel.org/linux-sound/20240430161012.4011064-1-perex@perex.cz/ Takashi Sakamoto (4): ALSA: pcm: delete snd_pcm_set_sync() in .open callback ALSA: pci: emu10k: delete usage of 'struct snd_pcm_runtime.sync' ALSA: core: delete sync member from snd_pcm_runtime structure ALSA: pcm: add notes to deprecate snd_pcm_sync_id in PCM interface for user space include/sound/pcm.h | 3 --- include/uapi/sound/asound.h | 5 +++-- sound/core/pcm_lib.c | 17 ----------------- sound/firewire/bebob/bebob_pcm.c | 1 - sound/firewire/dice/dice-pcm.c | 1 - sound/firewire/digi00x/digi00x-pcm.c | 1 - sound/firewire/fireface/ff-pcm.c | 1 - sound/firewire/fireworks/fireworks_pcm.c | 1 - sound/firewire/motu/motu-pcm.c | 1 - sound/firewire/oxfw/oxfw-pcm.c | 1 - sound/firewire/tascam/tascam-pcm.c | 1 - sound/isa/wss/wss_lib.c | 2 -- sound/pci/ali5451/ali5451.c | 1 - sound/pci/asihpi/asihpi.c | 2 -- sound/pci/ca0106/ca0106_main.c | 1 - sound/pci/echoaudio/echoaudio.c | 1 - sound/pci/emu10k1/p16v.c | 11 +---------- sound/pci/ens1370.c | 3 --- sound/pci/hda/hda_controller.c | 1 - sound/pci/ice1712/ice1712.c | 2 -- sound/pci/ice1712/ice1724.c | 5 ----- sound/pci/lx6464es/lx6464es.c | 1 - sound/pci/oxygen/oxygen_pcm.c | 1 - sound/pci/pcxhr/pcxhr.c | 1 - sound/pci/rme32.c | 4 ---- sound/pci/rme96.c | 4 ---- sound/pci/rme9652/hdsp.c | 2 -- sound/pci/rme9652/hdspm.c | 1 - sound/pci/rme9652/rme9652.c | 2 -- sound/pci/sis7019.c | 2 -- sound/pci/trident/trident_main.c | 2 -- sound/soc/intel/avs/pcm.c | 1 - sound/soc/intel/skylake/skl-pcm.c | 1 - sound/sparc/cs4231.c | 2 -- 34 files changed, 4 insertions(+), 82 deletions(-)