| Message ID | 20220927140948.17696-2-shangxiaojing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ff091dd23b423e19c8191928daedf62eab6ce523 |
| Headers | show |
| Series | ASoC: Use DIV_ROUND_UP() instead of open-coding it | expand |
On Tue, Sep 27, 2022 at 10:09:45PM +0800, Shang XiaoJing wrote: > Use DIV_ROUND_UP() instead of open-coding it, which intents and makes it > more clear what is going on for the casual reviewer. > > The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use > DIV_ROUND_UP() instead of open-coding it"). > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index 31ae752e242f..a078dd422ea1 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -918,8 +918,8 @@ static int cs35l36_dai_set_sysclk(struct snd_soc_dai *dai, int clk_id, fs1 = CS35L36_FS1_DEFAULT_VAL; fs2 = CS35L36_FS2_DEFAULT_VAL; } else { - fs1 = 3 * ((CS35L36_FS_NOM_6MHZ * 4 + freq - 1) / freq) + 4; - fs2 = 5 * ((CS35L36_FS_NOM_6MHZ * 4 + freq - 1) / freq) + 4; + fs1 = 3 * DIV_ROUND_UP(CS35L36_FS_NOM_6MHZ * 4, freq) + 4; + fs2 = 5 * DIV_ROUND_UP(CS35L36_FS_NOM_6MHZ * 4, freq) + 4; } regmap_write(cs35l36->regmap, CS35L36_TESTKEY_CTRL,
Use DIV_ROUND_UP() instead of open-coding it, which intents and makes it more clear what is going on for the casual reviewer. The Coccinelle references Commit e4d8aef21403 ("ALSA: usb: Use DIV_ROUND_UP() instead of open-coding it"). Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> --- sound/soc/codecs/cs35l36.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)