Hi Uwe, On Wed, 2023-03-15 at 16:05 +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de LGTM, Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > > > --- > sound/soc/cirrus/ep93xx-i2s.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c > index 70840f27d4a7..9760453d9d79 100644 > --- a/sound/soc/cirrus/ep93xx-i2s.c > +++ b/sound/soc/cirrus/ep93xx-i2s.c > @@ -495,19 +495,18 @@ static int ep93xx_i2s_probe(struct platform_device *pdev) > return err; > } > > -static int ep93xx_i2s_remove(struct platform_device *pdev) > +static void ep93xx_i2s_remove(struct platform_device *pdev) > { > struct ep93xx_i2s_info *info = dev_get_drvdata(&pdev->dev); > > clk_put(info->lrclk); > clk_put(info->sclk); > clk_put(info->mclk); > - return 0; > } > > static struct platform_driver ep93xx_i2s_driver = { > .probe = ep93xx_i2s_probe, > - .remove = ep93xx_i2s_remove, > + .remove_new = ep93xx_i2s_remove, > .driver = { > .name = "ep93xx-i2s", > },
diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c index 70840f27d4a7..9760453d9d79 100644 --- a/sound/soc/cirrus/ep93xx-i2s.c +++ b/sound/soc/cirrus/ep93xx-i2s.c @@ -495,19 +495,18 @@ static int ep93xx_i2s_probe(struct platform_device *pdev) return err; } -static int ep93xx_i2s_remove(struct platform_device *pdev) +static void ep93xx_i2s_remove(struct platform_device *pdev) { struct ep93xx_i2s_info *info = dev_get_drvdata(&pdev->dev); clk_put(info->lrclk); clk_put(info->sclk); clk_put(info->mclk); - return 0; } static struct platform_driver ep93xx_i2s_driver = { .probe = ep93xx_i2s_probe, - .remove = ep93xx_i2s_remove, + .remove_new = ep93xx_i2s_remove, .driver = { .name = "ep93xx-i2s", },
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- sound/soc/cirrus/ep93xx-i2s.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)