HDA: Missing Dock LineIn/Out with Lenovo L440 on Pro Dock

Commit Message

Takashi Iwai Oct. 8, 2014, 10:16 a.m. UTC

At Wed, 08 Oct 2014 11:40:35 +0200,
Sascha Wilde wrote:
> 
> Sascha Wilde <[e-mail]> writes:
> > using a Lenovo L440 Laptop on a Lenovo Pro Dock the combined line-in/out
> > jack at the docking station can not be used for output (input untested).
> [...]
> > I guess quirks for the pins leading to the external dock jack are
> > missing.
> 
> It seems the missing quirk is the same as for the T440:
> http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=1c37c22332a2d2c1b4ab32177a4f847c7fe06e38
> 
> Applying the pin config at module load time fixes the problem for me.
> 
> This hotfix as suggested by Jim Minter in:
> https://bugzilla.redhat.com/show_bug.cgi?id=1101386#c11
> is
> 
> # cat >/lib/firmware/tpt440dock-patch.fw <<EOF
> [codec]
> 0x10ec0292 0x17aa501e 0
> 
> [pincfg]
> 0x16 0x21211010
> 0x19 0x21a11010
> EOF
> 
> # cat >/etc/modprobe.d/hda-intel.conf <<EOF
> options snd-hda-intel
> patch=tpt440dock-patch.fw,tpt440dock-patch.fw,tpt440dock-patch.fw
> EOF
> 
> # rmmod snd_hda_intel
> # modprobe snd_hda_intel
> 
> So, alsa devs, could you please enable ALC292_FIXUP_TPT440_DOCK for
> ThinkPad L440 (codec 0x17aa, 0x501e)?

Sure, could you check the patch below?


Takashi

-- 8< --
From: Takashi Iwai <[e-mail]>
Subject: [PATCH] ALSA: hda - Add dock port support to Thinkpad L440 (71aa:501e)

Yet another Thinkpad model that has a dock port.

Reported-by: Sascha Wilde <[e-mail]>
Signed-off-by: Takashi Iwai <[e-mail]>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 2cc2568af016..bc86c36b4bfa 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4805,6 +4805,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),
 	SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_TPT440_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),