| Message ID | 1416830240-3019-1-git-send-email-nataraja@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 11/24/2014 03:57 AM, Vivek Natarajan wrote: > Increase the rts threshold from the legacy value of 2347 to support higher > threshold limit. Does any firmware actually support RTS? It didn't work last I tested it on 10.1. Thanks, Ben
Ben Greear <greearb@candelatech.com> writes: > On 11/24/2014 03:57 AM, Vivek Natarajan wrote: >> Increase the rts threshold from the legacy value of 2347 to support higher >> threshold limit. > > Does any firmware actually support RTS? It didn't work last I tested > it on 10.1. Vivek?
It works with the 10.2 firmware. Moreover, the issue reported here was rts_threshold displayed in debugfs was different than the one that we had configured to the firmware(2347) . Thanks
Vivek Natarajan <nataraja@qti.qualcomm.com> writes: > Increase the rts threshold from the legacy value of 2347 to support higher > threshold limit. > > Signed-off-by: Vivek Natarajan <nataraja@qti.qualcomm.com> Thanks, applied. In the future, please also CC linux-wireless as documented here: http://wireless.kernel.org/en/users/Drivers/ath10k/sources#Submitting_patches
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 8b60749..61f7e22 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -391,15 +391,11 @@ static int ath10k_mac_set_kickout(struct ath10k_vif *arvif) return 0; } -static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value) +static int ath10k_mac_set_rts(struct ath10k_vif *arvif, u32 value) { struct ath10k *ar = arvif->ar; u32 vdev_param; - if (value != 0xFFFFFFFF) - value = min_t(u32, arvif->ar->hw->wiphy->rts_threshold, - ATH10K_RTS_MAX); - vdev_param = ar->wmi.vdev_param->rts_threshold; return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, value); } diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index a38d788..8a4e779 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -4547,7 +4547,6 @@ struct wmi_dbglog_cfg_cmd { __le32 config_valid; } __packed; -#define ATH10K_RTS_MAX 2347 #define ATH10K_FRAGMT_THRESHOLD_MIN 540 #define ATH10K_FRAGMT_THRESHOLD_MAX 2346
Increase the rts threshold from the legacy value of 2347 to support higher threshold limit. Signed-off-by: Vivek Natarajan <nataraja@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 6 +----- drivers/net/wireless/ath/ath10k/wmi.h | 1 - 2 files changed, 1 insertion(+), 6 deletions(-)