| Message ID | 1421087564-10384-4-git-send-email-greearb@candelatech.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
greearb@candelatech.com writes: > From: Ben Greear <greearb@candelatech.com> > > This only happens on firmware crash, and it appears this > logic is not always perfect, so make sure the information > is printed to logs at higher level. > > Signed-off-by: Ben Greear <greearb@candelatech.com> > --- > drivers/net/wireless/ath/ath10k/pci.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c > index 0f7e845..dee0d5a 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -1132,9 +1132,8 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) > return; > } > > - ath10k_dbg(ar, ATH10K_DBG_PCI, > - "debug log header, dbuf: 0x%x dropped: %i\n", > - le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); > + ath10k_warn(ar, "debug log header, dbuf: 0x%x dropped: %i\n", > + le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); > dbufp = le32_to_cpu(dbg_hdr.dbuf); I think a new debug level is more approriate, this is just spamming the logs unnecessary.
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 0f7e845..dee0d5a 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1132,9 +1132,8 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) return; } - ath10k_dbg(ar, ATH10K_DBG_PCI, - "debug log header, dbuf: 0x%x dropped: %i\n", - le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); + ath10k_warn(ar, "debug log header, dbuf: 0x%x dropped: %i\n", + le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); dbufp = le32_to_cpu(dbg_hdr.dbuf); /* i is for logging purposes and sanity check in case firmware buffers @@ -1154,11 +1153,10 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) len = le32_to_cpu(dbuf.length); - ath10k_dbg(ar, ATH10K_DBG_PCI, - "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", - i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), - le32_to_cpu(dbuf.bufsize), len, - le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); + ath10k_warn(ar, "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", + i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), + le32_to_cpu(dbuf.bufsize), len, + le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); if (dbuf.buffer == 0 || len == 0) goto next;