| Message ID | 1423460814-2767-1-git-send-email-rmanohar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Feb 09, 2015 at 11:16:53AM +0530, Rajkumar Manoharan wrote: > Some of of qca988x solutions are having global reset issue > during target initialization. Bypassing PLL setting before > downloading firmware and letting the SoC run on REF_CLK is fixing > the problem. Corresponding firmware change is also needed to set > the clock source once the target is initialized. Since 10.2.4 > firmware is having this ROM patch, applying skip_clock_init only > for 10.2.4 firmware versions. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Kalle, Its been pending for a while. Shall I resend this series? -Rajkumar
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > Some of of qca988x solutions are having global reset issue > during target initialization. Bypassing PLL setting before > downloading firmware and letting the SoC run on REF_CLK is fixing > the problem. Corresponding firmware change is also needed to set > the clock source once the target is initialized. Since 10.2.4 > firmware is having this ROM patch, applying skip_clock_init only > for 10.2.4 firmware versions. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index 310e12b..cd20805 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -797,6 +797,16 @@ static int ath10k_download_cal_data(struct ath10k *ar) > ar->cal_mode = ATH10K_CAL_MODE_OTP; > > done: > + if ((ar->hw_rev == ATH10K_HW_QCA988X) && > + (ar->wmi.op_version == ATH10K_FW_WMI_OP_VERSION_10_2_4)) { > + ret = ath10k_bmi_write32(ar, hi_skip_clock_init, 1); > + if (ret) { > + ath10k_err(ar, "could not write skip_clock_init (%d)\n", > + ret); > + return ret; > + } > + } Didn't Michal mention that this should be a firmware feature flag? Checking for firmware versions can easily get too complicated, that's why we have tried to use feature flags for things like this. Also I think this should not be hidden inside ath10k_download_cal_data(). Maybe ath10k_core_start() is a better place to do this? I can send v3 for this patch.
On Thu, Mar 05, 2015 at 02:41:16PM +0200, Kalle Valo wrote: > Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > > > Some of of qca988x solutions are having global reset issue > > during target initialization. Bypassing PLL setting before > > downloading firmware and letting the SoC run on REF_CLK is fixing > > the problem. Corresponding firmware change is also needed to set > > the clock source once the target is initialized. Since 10.2.4 > > firmware is having this ROM patch, applying skip_clock_init only > > for 10.2.4 firmware versions. > > > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > > --- > > drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > > index 310e12b..cd20805 100644 > > --- a/drivers/net/wireless/ath/ath10k/core.c > > +++ b/drivers/net/wireless/ath/ath10k/core.c > > @@ -797,6 +797,16 @@ static int ath10k_download_cal_data(struct ath10k *ar) > > ar->cal_mode = ATH10K_CAL_MODE_OTP; > > > > done: > > + if ((ar->hw_rev == ATH10K_HW_QCA988X) && > > + (ar->wmi.op_version == ATH10K_FW_WMI_OP_VERSION_10_2_4)) { > > + ret = ath10k_bmi_write32(ar, hi_skip_clock_init, 1); > > + if (ret) { > > + ath10k_err(ar, "could not write skip_clock_init (%d)\n", > > + ret); > > + return ret; > > + } > > + } > > Didn't Michal mention that this should be a firmware feature flag? > Checking for firmware versions can easily get too complicated, that's > why we have tried to use feature flags for things like this. > Oops.. Sorry for the delay. I missed this mail. IIRC i replied to Michal's question for previous version. From the existing fw_feature flag, there is no clear way to identify 10.2.4 firmware version. Since this patch is needed only for 10.2.4, I used op_version. Otherwise fw_feature has to be extended for 10.2.4. Am i correct? > Also I think this should not be hidden inside > ath10k_download_cal_data(). Maybe ath10k_core_start() is a better place > to do this? > Hmm.. agree. > I can send v3 for this patch. > Thanks for taking care of this. Please let me know if you need help. -Rajkumar
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 310e12b..cd20805 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -797,6 +797,16 @@ static int ath10k_download_cal_data(struct ath10k *ar) ar->cal_mode = ATH10K_CAL_MODE_OTP; done: + if ((ar->hw_rev == ATH10K_HW_QCA988X) && + (ar->wmi.op_version == ATH10K_FW_WMI_OP_VERSION_10_2_4)) { + ret = ath10k_bmi_write32(ar, hi_skip_clock_init, 1); + if (ret) { + ath10k_err(ar, "could not write skip_clock_init (%d)\n", + ret); + return ret; + } + } + ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot using calibration mode %s\n", ath10k_cal_mode_str(ar->cal_mode)); return 0;
Some of of qca988x solutions are having global reset issue during target initialization. Bypassing PLL setting before downloading firmware and letting the SoC run on REF_CLK is fixing the problem. Corresponding firmware change is also needed to set the clock source once the target is initialized. Since 10.2.4 firmware is having this ROM patch, applying skip_clock_init only for 10.2.4 firmware versions. Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+)