| Message ID | 1423460814-2767-2-git-send-email-rmanohar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 02/08/2015 09:46 PM, Rajkumar Manoharan wrote: > Having lower number of copy engine entries for target to host > WMI ring is causing drops in receiving management frames. This > issue is observed during max clients (128 clients) stress testing. > While bursting deauthentication frames from simulated clients, > approx. 70% of frames are getting dropped due to lower ring entries. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c > b/drivers/net/wireless/ath/ath10k/pci.c > index e6972b0..f3174a6 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -113,7 +113,7 @@ static const struct ce_attr host_ce_config_wlan[] = { > .flags = CE_ATTR_FLAGS, > .src_nentries = 0, > .src_sz_max = 2048, > - .dest_nentries = 32, > + .dest_nentries = 128, > }, > > /* CE3: host->target WMI */ > @@ -183,7 +183,7 @@ static const struct ce_pipe_config > target_ce_config_wlan[] = { > { > .pipenum = __cpu_to_le32(2), > .pipedir = __cpu_to_le32(PIPEDIR_IN), > - .nentries = __cpu_to_le32(32), > + .nentries = __cpu_to_le32(64), Could you explain why the value of nentries are different? > .nbytes_max = __cpu_to_le32(2048), > .flags = __cpu_to_le32(CE_ATTR_FLAGS), > .reserved = __cpu_to_le32(0), Thanks, Peter
On Mon, Feb 09, 2015 at 02:54:00PM -0800, Peter Oh wrote: > > On 02/08/2015 09:46 PM, Rajkumar Manoharan wrote: > Could you explain why the value of nentries are different? There are separate copy engine configuration tables for host and target. Host-side and Target-side configurations are different and it never be same for any CE due to memory constraints in Target. -Rajkumar
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > Having lower number of copy engine entries for target to host > WMI ring is causing drops in receiving management frames. This > issue is observed during max clients (128 clients) stress testing. > While bursting deauthentication frames from simulated clients, > approx. 70% of frames are getting dropped due to lower ring entries. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> Thanks, patch 2 applied.
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index e6972b0..f3174a6 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -113,7 +113,7 @@ static const struct ce_attr host_ce_config_wlan[] = { .flags = CE_ATTR_FLAGS, .src_nentries = 0, .src_sz_max = 2048, - .dest_nentries = 32, + .dest_nentries = 128, }, /* CE3: host->target WMI */ @@ -183,7 +183,7 @@ static const struct ce_pipe_config target_ce_config_wlan[] = { { .pipenum = __cpu_to_le32(2), .pipedir = __cpu_to_le32(PIPEDIR_IN), - .nentries = __cpu_to_le32(32), + .nentries = __cpu_to_le32(64), .nbytes_max = __cpu_to_le32(2048), .flags = __cpu_to_le32(CE_ATTR_FLAGS), .reserved = __cpu_to_le32(0),
Having lower number of copy engine entries for target to host WMI ring is causing drops in receiving management frames. This issue is observed during max clients (128 clients) stress testing. While bursting deauthentication frames from simulated clients, approx. 70% of frames are getting dropped due to lower ring entries. Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)