| Message ID | 1427271291-31683-1-git-send-email-janusz.dziedzic@tieto.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes: > Firmwares that indicate BURST_SERVICE as enabled > could overwrite some wmm parameters (eg. txop). > This could lead IOT and balancing issues. > Hence disable this by default. > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com> There was a trivial conflict, please check my resolution in the pending branch.
2015-03-30 15:15 GMT+02:00 Kalle Valo <kvalo@qca.qualcomm.com>: > Janusz Dziedzic <janusz.dziedzic@tieto.com> writes: > >> Firmwares that indicate BURST_SERVICE as enabled >> could overwrite some wmm parameters (eg. txop). >> This could lead IOT and balancing issues. >> Hence disable this by default. >> >> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com> > > There was a trivial conflict, please check my resolution in the pending > branch. > Looks good. Thanks BR Janusz
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes: > Firmwares that indicate BURST_SERVICE as enabled > could overwrite some wmm parameters (eg. txop). > This could lead IOT and balancing issues. > Hence disable this by default. > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com> Thanks, applied.
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 75dcd3a..b0d550b 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3079,6 +3079,7 @@ static int ath10k_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant) static int ath10k_start(struct ieee80211_hw *hw) { struct ath10k *ar = hw->priv; + u32 burst_enable; int ret = 0; /* @@ -3133,6 +3134,15 @@ static int ath10k_start(struct ieee80211_hw *hw) goto err_core_stop; } + if (test_bit(WMI_SERVICE_BURST, ar->wmi.svc_map)) { + burst_enable = ar->wmi.pdev_param->burst_enable; + ret = ath10k_wmi_pdev_set_param(ar, burst_enable, 0); + if (ret) { + ath10k_warn(ar, "failed to disable burst: %d\n", ret); + goto err_core_stop; + } + } + if (ar->cfg_tx_chainmask) __ath10k_set_antenna(ar, ar->cfg_tx_chainmask, ar->cfg_rx_chainmask);
Firmwares that indicate BURST_SERVICE as enabled could overwrite some wmm parameters (eg. txop). This could lead IOT and balancing issues. Hence disable this by default. Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com> --- drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++ 1 file changed, 10 insertions(+)