diff mbox

ath10k: initialize features string in ath10k_print_driver_info() to prevent garbled dmesg output when fw_features == 0

Message ID 1438750948-3842-1-git-send-email-vvanpo@gmail.com (mailing list archive)
State Rejected
Headers show

Commit Message

Victor van Poppelen Aug. 5, 2015, 5:02 a.m. UTC
---
 drivers/net/wireless/ath/ath10k/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Aug. 13, 2015, 12:14 p.m. UTC | #1
Victor van Poppelen <vvanpo@gmail.com> writes:

> ---
>  drivers/net/wireless/ath/ath10k/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
> index 1a33bf0..5f32924 100644
> --- a/drivers/net/wireless/ath/ath10k/debug.c
> +++ b/drivers/net/wireless/ath/ath10k/debug.c
> @@ -124,7 +124,7 @@ EXPORT_SYMBOL(ath10k_info);
>  
>  void ath10k_print_driver_info(struct ath10k *ar)
>  {
> -	char fw_features[128];
> +	char fw_features[128] = "";

Michal already sent a patch for this:

https://github.com/kvalo/ath/commit/84e3df60f0daba5b1e7874101502d0b030afb867

Also your patch was missing a Signed-off-by and commit log. Please read
Documentation/SubmittingPatches for more info.
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 1a33bf0..5f32924 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -124,7 +124,7 @@  EXPORT_SYMBOL(ath10k_info);
 
 void ath10k_print_driver_info(struct ath10k *ar)
 {
-	char fw_features[128];
+	char fw_features[128] = "";
 
 	ath10k_core_get_fw_features_str(ar, fw_features, sizeof(fw_features));