diff mbox

latest ath10k pending tree bug's

Message ID 1459249346817.95969@qti.qualcomm.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Rajkumar Manoharan March 29, 2016, 11:02 a.m. UTC
> the new introduced code which initialized the precal data for new
> chipsets will break QCA99XX support.
> so ath10k fails to initialize.
> i commented out
> ret = ath10k_core_pre_cal_config(ar);
> and
>   ret = ath10k_core_pre_cal_download(ar);
> 
> to get it working again. this might not affect real pcie cards. but on
> IPQ8064 based boards with on board wifi cards it shows that behaviour.
> 
Can you please try below change?


> in addition this message here floods the kernel log
> [125917.204121] ath10k_pci 0001:01:00.0: failed to increase tx mgmt
> pending count: -16, dropping
> but it has no further visible side effects
> 
Yeah... It is harmless but better to lower debug level.

-Rajkumar

Comments

Sebastian Gottschall March 29, 2016, 4:02 p.m. UTC | #1
tryed  it . it works.

thanks for quick solution

Sebastian

Am 29.03.2016 um 13:02 schrieb Manoharan, Rajkumar:
>> the new introduced code which initialized the precal data for new
>> chipsets will break QCA99XX support.
>> so ath10k fails to initialize.
>> i commented out
>> ret = ath10k_core_pre_cal_config(ar);
>> and
>>    ret = ath10k_core_pre_cal_download(ar);
>>
>> to get it working again. this might not affect real pcie cards. but on
>> IPQ8064 based boards with on board wifi cards it shows that behaviour.
>>
> Can you please try below change?
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index ca45da3..cf90c87 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -725,10 +725,8 @@ struct ath10k {
>          const void *firmware_data;
>          size_t firmware_len;
>
> -       union {
> -               const struct firmware *pre_cal_file;
> -               const struct firmware *cal_file;
> -       };
> +       const struct firmware *pre_cal_file;
> +       const struct firmware *cal_file;
>
>          struct {
>                  const void *firmware_codeswap_data;
>
>> in addition this message here floods the kernel log
>> [125917.204121] ath10k_pci 0001:01:00.0: failed to increase tx mgmt
>> pending count: -16, dropping
>> but it has no further visible side effects
>>
> Yeah... It is harmless but better to lower debug level.
>
> -Rajkumar
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index ca45da3..cf90c87 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -725,10 +725,8 @@  struct ath10k {
        const void *firmware_data;
        size_t firmware_len;

-       union {
-               const struct firmware *pre_cal_file;
-               const struct firmware *cal_file;
-       };
+       const struct firmware *pre_cal_file;
+       const struct firmware *cal_file;

        struct {
                const void *firmware_codeswap_data;