diff mbox series

[1/3] ath10k: add wmi service peer stat info for wmi tlv

Message ID 1597312029-32348-2-git-send-email-wgong@codeaurora.org (mailing list archive)
State New, archived
Headers show
Series ath10k: correct tx/rx bitrate for QCA6174 PCIe and SDIO | expand

Commit Message

Wen Gong Aug. 13, 2020, 9:47 a.m. UTC
ath10k_sta_statistics is used to report info for iw wlan0 link,
it check ath10k_peer_stats_enabled, and ath10k_peer_stats_enabled
check WMI_SERVICE_PEER_STATS bit of ar->wmi.svc_map. SVCMAP() for
WMI_SERVICE_PEER_STATS was defined only for wmi_10x_svc_map and
wmi_10_4_svc_map interfaces, it missed in wmi_tlv_svc_map, so it is
not usable for iw wlan0 link for wmi tlv interface.

If firmware report WMI_TLV_SERVICE_PEER_STATS_INFO for wmi tlv, then
enable the WMI_SERVICE_PEER_STATS bit in ath10k, and then it pass check
in ath10k_peer_stats_enabled and ath10k_sta_statistics pass check.

Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048
Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1

Signed-off-by: Wen Gong <wgong@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/wmi-tlv.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kalle Valo Aug. 15, 2020, 7:05 a.m. UTC | #1
Wen Gong <wgong@codeaurora.org> wrote:

> ath10k_sta_statistics is used to report info for iw wlan0 link,
> it check ath10k_peer_stats_enabled, and ath10k_peer_stats_enabled
> check WMI_SERVICE_PEER_STATS bit of ar->wmi.svc_map. SVCMAP() for
> WMI_SERVICE_PEER_STATS was defined only for wmi_10x_svc_map and
> wmi_10_4_svc_map interfaces, it missed in wmi_tlv_svc_map, so it is
> not usable for iw wlan0 link for wmi tlv interface.
> 
> If firmware report WMI_TLV_SERVICE_PEER_STATS_INFO for wmi tlv, then
> enable the WMI_SERVICE_PEER_STATS bit in ath10k, and then it pass check
> in ath10k_peer_stats_enabled and ath10k_sta_statistics pass check.
> 
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
> 
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

3 patches applied to ath-next branch of ath.git, thanks.

e39f32afc6d2 ath10k: add wmi service peer stat info for wmi tlv
1cd6ba8ae33e ath10k: remove return for NL80211_STA_INFO_TX_BITRATE
cbcbabb9c395 ath10k: enable supports_peer_stats_info for QCA6174 PCI devices
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index e77b97ca5c7f..b39c9b78b32b 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
@@ -1614,6 +1614,8 @@  wmi_tlv_svc_map(const __le32 *in, unsigned long *out, size_t len)
 	       WMI_SERVICE_MESH_11S, len);
 	SVCMAP(WMI_TLV_SERVICE_SYNC_DELETE_CMDS,
 	       WMI_SERVICE_SYNC_DELETE_CMDS, len);
+	SVCMAP(WMI_TLV_SERVICE_PEER_STATS_INFO,
+	       WMI_SERVICE_PEER_STATS, len);
 }
 
 static inline void