diff mbox

[PATCH/RFT,0/2] ath10k: add qca6164 support

Message ID 2368480.ClS0E9V45b@wuerfel (mailing list archive)
State Not Applicable
Headers show

Commit Message

Arnd Bergmann Aug. 20, 2015, 1:22 p.m. UTC 
On Tuesday 18 August 2015 11:52:45 Oscar Rydberg wrote:
> I can confirm this patch did it for my Lenovo Yoga 3 14 with QCA6164, the
> WLAN interface is now alive, up and running perfectly fine!
> (After running modprobe -r ideapad-laptop that is, should anyone have
> trouble enabling it)
> 
> I had tried all the board.bin files from the windows drivers before, so the
> added sanity check seems to be what finally solved it.

I hope to test it in my Yoga 3 11 (1170) in the next days. Meanwhile, what is
the problem you see with the ideapad-laptop driver? I have recently submitted
a couple of bug fixes for the Yoga 1170, can you try if the patch below
fixes this for you?

	Arnd
	
commit 9d6d311add697014bdccb18d625db7e38676adbf
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Jun 13 15:13:11 2015 +0200

    ideapad: add rfkill whitelist entry for Yoga 3 1170
    
    This adds one more entry to the whitelist of machines that do not have
    a physical rfkill switch. Unfortunately, the Yoga 3 generation seems
    to use upper-case letters for the YOGA 3 Pro-1370, while it uses normal
    capitalization for its Yoga 3 1170 sibling.
    
    In order to catch all variants of the Yoga 3, I'm now using both strings
    as wildcards here, which should also cover the 1470 model, and possible
    changes in the string that could happen in firmware updates.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Comments

Kalle Valo Aug. 25, 2015, 1 p.m. UTC | #1 
Arnd Bergmann <arnd@arndb.de> writes:

> On Tuesday 18 August 2015 11:52:45 Oscar Rydberg wrote:
>> I can confirm this patch did it for my Lenovo Yoga 3 14 with QCA6164, the
>> WLAN interface is now alive, up and running perfectly fine!
>> (After running modprobe -r ideapad-laptop that is, should anyone have
>> trouble enabling it)
>> 
>> I had tried all the board.bin files from the windows drivers before, so the
>> added sanity check seems to be what finally solved it.

Odd, I didn't see this mail from Oscar and almost missed it. Maybe the
mailing list blocked it?

Anyway, thanks for testing. I'll try to get patch 1 to Linux 4.3 so that
it would have proper qca6164 support. If there are issues still, we can
fix those in a followup patch.
diff mbox

Patch

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index cb7cd8d79329..8e455c1429ee 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -855,7 +855,14 @@  static const struct dmi_system_id no_hw_rfkill_list[] = {
 		.ident = "Lenovo Yoga 3 Pro 1370",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 3 Pro-1370"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 3"),
+		},
+	},
+	{
+		.ident = "Lenovo Yoga 3 1170 / 1470",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Yoga 3"),
 		},
 	},
 	{}