diff mbox

ath10k: enable qca6174 hw3.2

Message ID 87r3ud21tq.fsf@kamboji.qca.qualcomm.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Kalle Valo Jan. 29, 2015, 12:44 p.m. UTC 
Michal Kazior <michal.kazior@tieto.com> writes:

> The 3.2 revision has a different target BMI
> version so it wasn't recognized by ath10k (despite
> the chip_id rev being on the supported list
> already).
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

But uses the same binaries as hw3.0?

> +	{
> +		.id = QCA6174_HW_3_2_VERSION,
> +		.name = "qca6174 hw3.2",
> +		.patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR,
> +		.uart_pin = 6,
> +		.fw = {
> +			.dir = QCA6174_HW_3_0_FW_DIR,
> +			.fw = QCA6174_HW_3_0_FW_FILE,
> +			.otp = QCA6174_HW_3_0_OTP_FILE,
> +			.board = QCA6174_HW_3_0_BOARD_DATA_FILE,
> +			.board_size = QCA6174_BOARD_DATA_SZ,
> +			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
> +		},
> +	},
>  };

I added this in pending branch to avoid people wondering why it uses 3.0
binaries:

Comments

Michal Kazior Jan. 29, 2015, 12:59 p.m. UTC | #1 
On 29 January 2015 at 13:44, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> The 3.2 revision has a different target BMI
>> version so it wasn't recognized by ath10k (despite
>> the chip_id rev being on the supported list
>> already).
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> But uses the same binaries as hw3.0?

Correct.


[...]
> I added this in pending branch to avoid people wondering why it uses 3.0
> binaries:
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 36a8fcf349fa..310e12bc078a 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -91,6 +91,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>                 .patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR,
>                 .uart_pin = 6,
>                 .fw = {
> +                       /* uses same binaries as hw3.0 */

Good point. Thanks!


Micha?
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 36a8fcf349fa..310e12bc078a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -91,6 +91,7 @@  static const struct ath10k_hw_params ath10k_hw_params_list[] = {
                .patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR,
                .uart_pin = 6,
                .fw = {
+                       /* uses same binaries as hw3.0 */
                        .dir = QCA6174_HW_3_0_FW_DIR,
                        .fw = QCA6174_HW_3_0_FW_FILE,
                        .otp = QCA6174_HW_3_0_OTP_FILE,