| Message ID | CAAf+CsCKx3p=TdWZxbSi9JRfKUicCqyAUaP-Kzxgj1N6XK0WqQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Kalle Valo |
| Headers | show |
Guilherme Íscaro <cabelitostos@gmail.com> writes: > I would like to inform that I "fixed" the problem. After my last > email, I cloned the linux repo and started to hack around the driver > source code. By looking at the dmesg output that I provided to you > guys, I noticed that for some reason the board was not being properly > awake ( ath10k_pci_wake_wait() returns ETIMEOUT). I so sick with this > problem that I hardcoded "ar_pci->pci_ps" to false, thus the board > can't sleep now. Sounds like a problem with your PCI bus or the platform/laptop so try different PCI settings both on BIOS and kernel. I have seen lots of talk about ASPM, especially with some iwlwifi devices, so you should also investigate about that. Please let us know if you find anything, it's always valuable information. Have fun googling :) -- Kalle Valo
hiya, hm, what's the reference driver do for pci powersave versus aspm? Does it change any pci config space register settings for allowable sleep states? -adrian On 31 March 2017 at 04:12, Kalle Valo <kvalo@qca.qualcomm.com> wrote: > Guilherme Íscaro <cabelitostos@gmail.com> writes: > >> I would like to inform that I "fixed" the problem. After my last >> email, I cloned the linux repo and started to hack around the driver >> source code. By looking at the dmesg output that I provided to you >> guys, I noticed that for some reason the board was not being properly >> awake ( ath10k_pci_wake_wait() returns ETIMEOUT). I so sick with this >> problem that I hardcoded "ar_pci->pci_ps" to false, thus the board >> can't sleep now. > > Sounds like a problem with your PCI bus or the platform/laptop so try > different PCI settings both on BIOS and kernel. I have seen lots of talk > about ASPM, especially with some iwlwifi devices, so you should also > investigate about that. > > Please let us know if you find anything, it's always valuable > information. Have fun googling :) > > -- > Kalle Valo > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k
Hi, I have a question Are you sure this is an ASPM problem? I've disable pcie_aspm during boot (Kernel boot option - pcie_aspm=off) and the problem still persists. 2017-03-31 12:11 GMT-03:00 Adrian Chadd <adrian@freebsd.org>: > hiya, > > hm, what's the reference driver do for pci powersave versus aspm? Does > it change any pci config space register settings for allowable sleep > states? > > > > -adrian > > > On 31 March 2017 at 04:12, Kalle Valo <kvalo@qca.qualcomm.com> wrote: >> Guilherme Íscaro <cabelitostos@gmail.com> writes: >> >>> I would like to inform that I "fixed" the problem. After my last >>> email, I cloned the linux repo and started to hack around the driver >>> source code. By looking at the dmesg output that I provided to you >>> guys, I noticed that for some reason the board was not being properly >>> awake ( ath10k_pci_wake_wait() returns ETIMEOUT). I so sick with this >>> problem that I hardcoded "ar_pci->pci_ps" to false, thus the board >>> can't sleep now. >> >> Sounds like a problem with your PCI bus or the platform/laptop so try >> different PCI settings both on BIOS and kernel. I have seen lots of talk >> about ASPM, especially with some iwlwifi devices, so you should also >> investigate about that. >> >> Please let us know if you find anything, it's always valuable >> information. Have fun googling :) >> >> -- >> Kalle Valo >> _______________________________________________ >> ath10k mailing list >> ath10k@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/ath10k
(please don't top post) Guilherme Íscaro <cabelitostos@gmail.com> writes: > Hi, I have a question To whom? > Are you sure this is an ASPM problem? I've disable pcie_aspm during > boot (Kernel boot option - pcie_aspm=off) and the problem still > persists. ASPM was just one area to investigate. The real problem could be anywhere. -- Kalle Valo
From c3bc3e52998d8b6189da00391570359e17d1d359 Mon Sep 17 00:00:00 2001 From: Guilherme Iscaro <iscaro@profusion.mobi> Date: Tue, 21 Mar 2017 10:05:40 -0300 Subject: [PATCH] FIX BUG. --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index b541a1c74488..0da470b0aee4 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -3187,7 +3187,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev, case QCA6164_2_1_DEVICE_ID: case QCA6174_2_1_DEVICE_ID: hw_rev = ATH10K_HW_QCA6174; - pci_ps = true; + pci_ps = false; pci_soft_reset = ath10k_pci_warm_reset; pci_hard_reset = ath10k_pci_qca6174_chip_reset; break; -- 2.12.1