diff mbox series

ath11k: fix itnull.cocci warnings

Message ID alpine.DEB.2.21.1903072236250.2558@hadrien (mailing list archive)
State New, archived
Headers show
Series ath11k: fix itnull.cocci warnings | expand

Commit Message

Julia Lawall March 7, 2019, 9:37 p.m. UTC 
From: kbuild test robot <lkp@intel.com>

Iterator variable bound on line 976 cannot be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Fixes: 258bbf525e65 ("ath11k: add driver")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/42] ath11k: add driver
:::::: branch date: 5 hours ago
:::::: commit date: 4 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 dp_rx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo March 8, 2019, 12:48 p.m. UTC | #1 
Julia Lawall <julia.lawall@lip6.fr> writes:

> From: kbuild test robot <lkp@intel.com>
>
> Iterator variable bound on line 976 cannot be NULL.
>
> Generated by: scripts/coccinelle/iterators/itnull.cocci
>
> Fixes: 258bbf525e65 ("ath11k: add driver")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Doesn't apply either.
diff mbox series

Patch

--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -974,7 +974,7 @@  struct htt_ppdu_stats_info *ath11k_dp_ht
 	struct htt_ppdu_stats *ppdu_stats = NULL;

 	list_for_each_entry(ppdu_info, &ar->ppdu_stats_info, list) {
-		if (ppdu_info && ppdu_info->ppdu_id == ppdu_id)
+		if (ppdu_info->ppdu_id == ppdu_id)
 			return ppdu_info;
 	}