diff mbox

cifs: ensure that cifs_readpages calls cifsFileInfo_get under the cifs_file_list_lock

Message ID 1342799330-2919-1-git-send-email-jlayton@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jeff Layton July 20, 2012, 3:48 p.m. UTC 
...regression introduced in 6993f74a5.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/cifs/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Layton July 23, 2012, 12:18 p.m. UTC | #1 
On Fri, 20 Jul 2012 11:48:50 -0400
Jeff Layton <jlayton@redhat.com> wrote:

> ...regression introduced in 6993f74a5.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
>  fs/cifs/file.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 513adbc..45508cf 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -3083,8 +3083,8 @@ static int cifs_readpages(struct file *file, struct address_space *mapping,
>  		}
>  
>  		spin_lock(&cifs_file_list_lock);
> -		spin_unlock(&cifs_file_list_lock);
>  		rdata->cfile = cifsFileInfo_get(open_file);
> +		spin_unlock(&cifs_file_list_lock);
>  		rdata->mapping = mapping;
>  		rdata->offset = offset;
>  		rdata->bytes = bytes;

Now that 3.5 has shipped, this patch needs to Cc: stable when it's included.

Cheers,
diff mbox

Patch

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 513adbc..45508cf 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -3083,8 +3083,8 @@  static int cifs_readpages(struct file *file, struct address_space *mapping,
 		}
 
 		spin_lock(&cifs_file_list_lock);
-		spin_unlock(&cifs_file_list_lock);
 		rdata->cfile = cifsFileInfo_get(open_file);
+		spin_unlock(&cifs_file_list_lock);
 		rdata->mapping = mapping;
 		rdata->offset = offset;
 		rdata->bytes = bytes;